Re: [PATCH 1/6] object-file: move logic to read loose objects into backend

[Patrick Steinhardt <ps@pks.im>]

On Tue, Nov 10, 2026 at 06:40:59PM +0530, Kaartic Sivaraam wrote:
> On 11/2/26 16:50, Patrick Steinhardt wrote:
> > diff --git a/object-file.h b/object-file.h
> > index f44758c4f8b..65ab44542b0 100644
> > --- a/object-file.h
> > +++ b/object-file.h
> > @@ -122,50 +121,6 @@ void hash_object_file(const struct git_hash_algo *algo, const void *buf,
> >   int check_and_freshen_file(const char *fn, int freshen,
> >   			   const time_t *mtime);
> > -/*
> > - * Open the loose object at path, check its hash, and return the contents,
> > - * use the "oi" argument to assert things about the object, or e.g. populate its
> > - * type, and size. If the object is a blob, then "contents" may return NULL,
> > - * to allow streaming of large blobs.
> > - *
> > - * Returns 0 on success, negative on error (details may be written to stderr).
> > - */
> 
> We're losing these documentation comments during the move. Can we retain the
> same above the static functions in odb/source-loose.c?

Sure, can do.

Patrick