Re: [PATCH 2/6] object-file: move logic to derive loose object paths into backend

[Patrick Steinhardt <ps@pks.im>]

On Tue, Nov 10, 2026 at 06:58:34PM +0530, Kaartic Sivaraam wrote:
> On 11/2/26 16:50, Patrick Steinhardt wrote:
> > diff --git a/odb/source-loose.c b/odb/source-loose.c
> > index 96fc2ed213f..0f29162d752 100644
> > --- a/odb/source-loose.c
> > +++ b/odb/source-loose.c
> > @@ -18,6 +18,27 @@
> >   #include "tempfile.h"
> >   #include "write-or-die.h"
> > +const char *odb_loose_path(struct odb_source_loose *loose,
> > +			   struct strbuf *buf,
> > +			   const struct object_id *oid)
> > +{
> > +	static const char hex[] = "0123456789abcdef";
> > +
> 
> The hex[] gained a const while moving but that looks obviously correct.
> 
> Rest of the move looks good to me. We didn't lose anything. One thing I
> noticed is that http-walker.c no longer needs the object-file.c include now.
> So, we could also include the following in this patch:
> 
> diff --git a/http-walker.c b/http-walker.c
> index 13730a2784..05c0262810 100644
> --- a/http-walker.c
> +++ b/http-walker.c
> @@ -9,7 +9,6 @@
>  #include "list.h"
>  #include "transport.h"
>  #include "packfile.h"
> -#include "object-file.h"
>  #include "odb.h"
>  #include "odb/source-loose.h"

It still needs that header at this step though. But it doesn't need it
anymore after patch 5, so let me fold that in there.

Patrick