Git development
 help / color / mirror / Atom feed
* [PATCH 0/3] compatObjectFormat: fix a BUG(), wrong id and unknown headers
@ 2026-11-12 19:57 Adrian Ratiu
  2026-11-12 19:57 ` [PATCH 1/3] setup: reject compatObjectFormat == objectFormat Adrian Ratiu
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Adrian Ratiu @ 2026-11-12 19:57 UTC (permalink / raw)
  To: git
  Cc: Junio C Hamano, Patrick Steinhardt, brian m . carlson,
	Eric W . Biederman, Axel Rasmussen, Emily Shaffer, Josh Steadmon,
	Adrian Ratiu

Hello all,

I've been continuing my three-way Git, Gitoxide and Jujutsu sha1-sha256
interop testing and uncovered three more bugs, this time in Git's
compatObjectFormat.

I'm reasonably confident in the first two patches.

The last patch needs careful review, because there are two conflicting
behaviors: Git copies unknown commit headers when it creates commits,
but rejects them when converting existing ones.

I made both copy them, which removes a check added on purpose in
08a45903cb (object-file-convert: convert commits that embed signed tags,
2023-10-01) and I'm not 100% sure it's the right direction.

More details in the commit messages.

Many thanks,
Adrian

Adrian Ratiu (3):
  setup: reject compatObjectFormat == objectFormat
  rev-parse: die when --output-object-format cannot map an object
  object-file-convert: copy unknown commit headers unchanged

 builtin/rev-parse.c           |  8 +++++---
 object-file-convert.c         | 21 +++++++++++----------
 setup.c                       |  7 +++++++
 t/t1016-compatObjectFormat.sh | 18 ++++++++++++++++++
 t/t1302-repo-version.sh       | 14 ++++++++++++++
 t/t1500-rev-parse.sh          | 18 ++++++++++++++++++
 6 files changed, 73 insertions(+), 13 deletions(-)

-- 
2.56.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2026-11-17 15:28 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-12 19:57 [PATCH 0/3] compatObjectFormat: fix a BUG(), wrong id and unknown headers Adrian Ratiu
2026-11-12 19:57 ` [PATCH 1/3] setup: reject compatObjectFormat == objectFormat Adrian Ratiu
2026-11-16  7:36   ` Patrick Steinhardt
2026-11-17 10:42     ` Adrian Ratiu
2026-11-12 19:57 ` [PATCH 2/3] rev-parse: die when --output-object-format cannot map an object Adrian Ratiu
2026-11-16  7:37   ` Patrick Steinhardt
2026-11-17 11:55     ` Adrian Ratiu
2026-11-12 19:57 ` [PATCH 3/3] object-file-convert: copy unknown commit headers unchanged Adrian Ratiu
2026-11-16  7:37   ` Patrick Steinhardt
2026-11-17 15:27     ` Adrian Ratiu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox