From: Justin Tobler <jltobler@gmail.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 4/4] object-file: create ODB transaction temporary directory eagerly
Date: Tue, 17 Nov 2026 17:57:48 -0600 [thread overview]
Message-ID: <avzn-Zz5-h1haIEq@denethor> (raw)
In-Reply-To: <CAOLa=ZShhVC=7uYs4_CP6pUSuiYziQrbN8EbJhpqYToixPV-VA@mail.gmail.com>
On 26/11/11 08:48AM, Karthik Nayak wrote:
> Justin Tobler <jltobler@gmail.com> writes:
>
> > Typically large numbers of loose objects are not expected to be written
> > into an ODB transaction so the overhead here should be marginal.
>
> Question: why is that?
Loose objects are only written to a transaction if the number of objects
in the incoming packfile are below the unpack limit (default 100
objects) or by objects being added. Of course it is possible that a user
could add a new tree with a large number of objects for the first time
though. There real point here though is that the overhead here is per
object and small in comparison to the cost of writting the object in the
first place. In most cases, I wouldn't expect it to be noticed. I'll try
to update the message here to be a bit more clear.
-Justin
next prev parent reply other threads:[~2026-11-17 23:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 0:22 [PATCH 0/4] object-file: eagerly create ODB transaction temporary directory Justin Tobler
2026-11-10 0:22 ` [PATCH 1/4] object-file: rename default transaction prefix Justin Tobler
2026-11-11 13:15 ` Patrick Steinhardt
2026-11-11 14:36 ` Karthik Nayak
2026-11-10 0:22 ` [PATCH 2/4] object-file: only flush batched fsync writes when enabled Justin Tobler
2026-11-11 13:16 ` Patrick Steinhardt
2026-11-17 23:35 ` Justin Tobler
2026-11-11 14:48 ` Karthik Nayak
2026-11-17 23:42 ` Justin Tobler
2026-11-10 0:22 ` [PATCH 3/4] tmp-objdir: preserve errno when directory creation fails Justin Tobler
2026-11-11 13:16 ` Patrick Steinhardt
2026-11-11 16:44 ` Karthik Nayak
2026-11-17 23:46 ` Justin Tobler
2026-11-10 0:22 ` [PATCH 4/4] object-file: create ODB transaction temporary directory eagerly Justin Tobler
2026-11-11 13:15 ` Patrick Steinhardt
2026-11-17 23:48 ` Justin Tobler
2026-11-11 16:48 ` Karthik Nayak
2026-11-17 23:57 ` Justin Tobler [this message]
2026-11-11 14:33 ` [PATCH 0/4] object-file: eagerly create ODB transaction temporary directory Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avzn-Zz5-h1haIEq@denethor \
--to=jltobler@gmail.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox