Git development
 help / color / mirror / Atom feed
From: Justin Tobler <jltobler@gmail.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 4/4] object-file: create ODB transaction temporary directory eagerly
Date: Tue, 17 Nov 2026 17:48:23 -0600	[thread overview]
Message-ID: <avznZz5351gjqPVQ@denethor> (raw)
In-Reply-To: <avRqiH9eIpJUGKMo@pks.im>

On 26/11/11 02:15PM, Patrick Steinhardt wrote:
> On Mon, Nov 09, 2026 at 06:22:51PM -0600, Justin Tobler wrote:
> > +	prefix = flags & ODB_TRANSACTION_RECEIVE ? "incoming" : "transaction";
> 
> Makes me wonder whether it's important to keep the "incoming" prefix
> here or whether there is an argument to be made that it should simply be
> called "transaction", as well.
> 
> That may be out of scope for this series though.

Ya, this is something I would also like to change, but I decided to
leave it for a future series. :)

[snip]
> > diff --git a/t/t0004-unwritable.sh b/t/t0004-unwritable.sh
> > index 3bdafbae0f..7292672a66 100755
> > --- a/t/t0004-unwritable.sh
> > +++ b/t/t0004-unwritable.sh
> > @@ -24,8 +24,8 @@ test_expect_success POSIXPERM,SANITY 'write-tree should notice unwritable reposi
> >  test_lazy_prereq WRITE_TREE_OUT 'test -e "$TRASH_DIRECTORY"/out.write-tree'
> >  test_expect_success WRITE_TREE_OUT 'write-tree output on unwritable repository' '
> >  	cat >expect <<-\EOF &&
> > -	error: insufficient permission for adding an object to repository database .git/objects
> > -	fatal: git-write-tree: error building trees
> > +	error: unable to create temporary object directory in .git/objects: Permission denied
> > +	fatal: failed to start ODB transaction
> 
> Not a new issue, but this second error message is awful. An average user
> won't have any idea what an "ODB" even is. s/ODB/object/ would make a
> lot more sense.

I agree. I'll add another small patch in the next version that changes
this.

-Justin

  reply	other threads:[~2026-11-17 23:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  0:22 [PATCH 0/4] object-file: eagerly create ODB transaction temporary directory Justin Tobler
2026-11-10  0:22 ` [PATCH 1/4] object-file: rename default transaction prefix Justin Tobler
2026-11-11 13:15   ` Patrick Steinhardt
2026-11-11 14:36   ` Karthik Nayak
2026-11-10  0:22 ` [PATCH 2/4] object-file: only flush batched fsync writes when enabled Justin Tobler
2026-11-11 13:16   ` Patrick Steinhardt
2026-11-17 23:35     ` Justin Tobler
2026-11-11 14:48   ` Karthik Nayak
2026-11-17 23:42     ` Justin Tobler
2026-11-10  0:22 ` [PATCH 3/4] tmp-objdir: preserve errno when directory creation fails Justin Tobler
2026-11-11 13:16   ` Patrick Steinhardt
2026-11-11 16:44   ` Karthik Nayak
2026-11-17 23:46     ` Justin Tobler
2026-11-10  0:22 ` [PATCH 4/4] object-file: create ODB transaction temporary directory eagerly Justin Tobler
2026-11-11 13:15   ` Patrick Steinhardt
2026-11-17 23:48     ` Justin Tobler [this message]
2026-11-11 16:48   ` Karthik Nayak
2026-11-17 23:57     ` Justin Tobler
2026-11-11 14:33 ` [PATCH 0/4] object-file: eagerly create ODB transaction temporary directory Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avznZz5351gjqPVQ@denethor \
    --to=jltobler@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox