[BUG] stgit: unexpected "unknown user details" on refresh

[BUG] stgit: unexpected "unknown user details" on refresh

[Yann Dirson]

Hi Catalin,

Here is an error I just got when refreshing.  The refresh did occur, but
the error is annoying and may hide something:

dwitch@gandelf:/export/work/yann/git/stgit$ ./stg ref contrib/stg-whatchanged
Checking for changes in the working directory... done
Refreshing patch "whatchanged"...stg ref: unknown user details

dwitch@gandelf:/export/work/yann/git/stgit$ echo $?
2


When using "refresh -p", we can see the error occurs before rewinding to
current patch:

dwitch@gandelf:/export/work/yann/git/stgit$ ./stg ref -p show-old
Checking for changes in the working directory... done
Popping patch "whatchanged"... done
Refreshing patch "show-old"...stg ref: unknown user details

dwitch@gandelf:/export/work/yann/git/stgit$ stg top
show-old

Re: [BUG] stgit: unexpected "unknown user details" on refresh

[Catalin Marinas]

On 04/01/07, Yann Dirson <ydirson@altern.org> wrote:
> Here is an error I just got when refreshing.  The refresh did occur, but
> the error is annoying and may hide something:
>
> dwitch@gandelf:/export/work/yann/git/stgit$ ./stg ref contrib/stg-whatchanged
> Checking for changes in the working directory... done
> Refreshing patch "whatchanged"...stg ref: unknown user details

I changed StGIT to use the same configuration file as GIT and it
cannot find the user information. To remove the error:

  git repo-config --global user.name Yann Dirson
  git repo-config --global user.email ydirson@altern.org

It probably tries to set the author information for the patch and
GIT_AUTH* or GIT_COMMIT* aren't set but it would be probably useful to
get the full backtrace of this error (at the end of the stgit/main.py
file, just add a "raise" before sys.exit(2)).

-- 
Catalin

Re: [BUG] stgit: unexpected "unknown user details" on refresh

[Yann Dirson]

On Fri, Jan 05, 2007 at 09:07:51AM +0000, Catalin Marinas wrote:
> It probably tries to set the author information for the patch and
> GIT_AUTH* or GIT_COMMIT* aren't set but it would be probably useful to
> get the full backtrace of this error (at the end of the stgit/main.py
> file, just add a "raise" before sys.exit(2)).

Email vars are set, name is taken (by git) from GECOS.  Apparently
StGIT does not use the latter.  It would surely be more user-friendly
to use it, as much for providing a (hopefully) sane default as to get
a behaviour consistent with GIT.

$ env|grep GIT
GIT_COMMITTER_EMAIL=ydirson@altern.org
GIT_AUTHOR_EMAIL=ydirson@altern.org

As you expected:

Traceback (most recent call last):
  File "./stg", line 43, in ?
    main()
  File "/export/work/yann/git/stgit/stgit/main.py", line 262, in main
    command.func(parser, options, args)
  File "/export/work/yann/git/stgit/stgit/commands/refresh.py", line 145, in func
    backup = True, sign_str = sign_str)
  File "/export/work/yann/git/stgit/stgit/stack.py", line 674, in refresh_patch
    patch.set_authdate(author_date)
  File "/export/work/yann/git/stgit/stgit/stack.py", line 265, in set_authdate
    self._set_field('authdate', date or git.author().date)
  File "/export/work/yann/git/stgit/stgit/git.py", line 475, in author
    __author = user()
  File "/export/work/yann/git/stgit/stgit/git.py", line 457, in user
    raise GitException, 'unknown user details'
stgit.git.GitException: unknown user details

Best regards,
-- 
Yann.