From: Muhammed Dilshad A <dilsheddilu123@gmail.com>
To: git@vger.kernel.org
Cc: ps@pks.im, Muhammed Dilshad A <dilsheddilu123@gmail.com>
Subject: [PATCH v2 0/3] mergesort: move tests to Clar and retire the helper
Date: Wed, 7 Oct 2026 19:20:22 +0530 [thread overview]
Message-ID: <cover.1791365181.git.dilsheddilu123@gmail.com> (raw)
In-Reply-To: <20261007034205.32619-1-dilsheddilu123@gmail.com>
Hi Patrick,
Thanks for the review. I followed up on the larger cleanup you mentioned.
The sorting tests now run in Clar, and I have removed the old benchmark
and its helper. This also removes the unused generate subcommand.
The new suite keeps all 1,680 cases from the old certification test and
adds checks for empty and small lists using both sort macros. It checks
sorting order, stability and list length. Cleanup frees the backing
arrays directly, so a failed assertion does not need to walk list links.
Changes since v1:
* Patch 1 is unchanged.
* Patch 2 moves the tests to Clar and removes the unused generate and
test commands. The sort command remains available for the benchmark.
* Patch 3 removes p0071 and the remaining sort helper, along with their
build and command registrations.
I kept the leak fix first so it can still be applied on its own if you
would prefer to keep the broader cleanup for a separate series.
The Make and Meson unit tests pass, and the mergesort unit suite also
passes with LeakSanitizer enabled. The production sorting implementation
is unchanged.
Muhammed Dilshad A (3):
test-mergesort: plug memory leaks in sort_stdin()
mergesort: move sorting tests to the unit-test framework
t: retire the sorting benchmark and mergesort helper
Makefile | 2 +-
t/helper/meson.build | 1 -
t/helper/test-mergesort.c | 408 -------------------------------------
t/helper/test-tool.c | 1 -
t/helper/test-tool.h | 1 -
t/meson.build | 3 +-
t/perf/p0071-sort.sh | 52 -----
t/t0071-sort.sh | 11 -
t/unit-tests/u-mergesort.c | 369 +++++++++++++++++++++++++++++++++
9 files changed, 371 insertions(+), 477 deletions(-)
delete mode 100644 t/helper/test-mergesort.c
delete mode 100755 t/perf/p0071-sort.sh
delete mode 100755 t/t0071-sort.sh
create mode 100644 t/unit-tests/u-mergesort.c
base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd
--
2.55.0
next prev parent reply other threads:[~2026-10-07 13:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 3:42 [PATCH] test-mergesort: plug memory leaks in sort_stdin() Muhammed Dilshad A
2026-10-07 6:13 ` Patrick Steinhardt
2026-10-07 17:27 ` Junio C Hamano
2026-10-07 13:50 ` Muhammed Dilshad A [this message]
2026-10-07 13:50 ` [PATCH v2 1/3] " Muhammed Dilshad A
2026-10-07 13:50 ` [PATCH v2 2/3] mergesort: move sorting tests to the unit-test framework Muhammed Dilshad A
2026-10-09 11:52 ` Patrick Steinhardt
2026-10-09 13:55 ` Muhammed Dilshad A
2026-10-07 13:50 ` [PATCH v2 3/3] t: retire the sorting benchmark and mergesort helper Muhammed Dilshad A
2026-10-09 11:52 ` [PATCH v2 0/3] mergesort: move tests to Clar and retire the helper Patrick Steinhardt
2026-10-09 13:56 ` Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 0/4] mergesort: move tests to Clar and remove " Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 1/4] mergesort: move sorting tests to Clar Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 2/4] mergesort: simplify the unit tests Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 3/4] mergesort: cover empty and small lists Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 4/4] t: retire the sorting benchmark and mergesort helper Muhammed Dilshad A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1791365181.git.dilsheddilu123@gmail.com \
--to=dilsheddilu123@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox