Git development
 help / color / mirror / Atom feed
From: Muhammed Dilshad A <dilsheddilu123@gmail.com>
To: git@vger.kernel.org
Cc: ps@pks.im, Muhammed Dilshad A <dilsheddilu123@gmail.com>
Subject: [PATCH v3 0/4] mergesort: move tests to Clar and remove the helper
Date: Fri,  9 Oct 2026 20:38:46 +0530	[thread overview]
Message-ID: <cover.1791556668.git.dilsheddilu123@gmail.com> (raw)
In-Reply-To: <cover.1791365181.git.dilsheddilu123@gmail.com>

Move the mergesort checks from the shell test and helper into Clar, where
the tests call the sort functions directly.

Simplify the old distribution/mode grid to direct tests for sorted,
reversed, equal-value and repeatable random input. Keep the checks for
sorted values, the original order of equal values, and list length. Add
empty and small-list cases and a check of the debug hooks separately.
The final tests cover fewer input combinations than the old certification
test.

Retire p0071, the benchmark used to compare sorting implementations.
This removes the last user of the mergesort helper, so remove that too.

The migration, simplification, additional tests and benchmark removal are
separate commits.

Changes since v2:

* Drop the leak-fix patch, since this series removes the helper.
* Simplify the test inputs and remove the distribution/mode tables.
* Put the additional tests in their own commit.
* Rewrite the commit messages to explain the changes more clearly.

Muhammed Dilshad A (4):
  mergesort: move sorting tests to Clar
  mergesort: simplify the unit tests
  mergesort: cover empty and small lists
  t: retire the sorting benchmark and mergesort helper

 Makefile                   |   2 +-
 t/helper/meson.build       |   1 -
 t/helper/test-mergesort.c  | 408 -------------------------------------
 t/helper/test-tool.c       |   1 -
 t/helper/test-tool.h       |   1 -
 t/meson.build              |   3 +-
 t/perf/p0071-sort.sh       |  52 -----
 t/t0071-sort.sh            |  11 -
 t/unit-tests/u-mergesort.c | 168 +++++++++++++++
 9 files changed, 170 insertions(+), 477 deletions(-)
 delete mode 100644 t/helper/test-mergesort.c
 delete mode 100755 t/perf/p0071-sort.sh
 delete mode 100755 t/t0071-sort.sh
 create mode 100644 t/unit-tests/u-mergesort.c


base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd
-- 
2.55.0


  parent reply	other threads:[~2026-10-09 15:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07  3:42 [PATCH] test-mergesort: plug memory leaks in sort_stdin() Muhammed Dilshad A
2026-10-07  6:13 ` Patrick Steinhardt
2026-10-07 17:27   ` Junio C Hamano
2026-10-07 13:50 ` [PATCH v2 0/3] mergesort: move tests to Clar and retire the helper Muhammed Dilshad A
2026-10-07 13:50   ` [PATCH v2 1/3] test-mergesort: plug memory leaks in sort_stdin() Muhammed Dilshad A
2026-10-07 13:50   ` [PATCH v2 2/3] mergesort: move sorting tests to the unit-test framework Muhammed Dilshad A
2026-10-09 11:52     ` Patrick Steinhardt
2026-10-09 13:55       ` Muhammed Dilshad A
2026-10-07 13:50   ` [PATCH v2 3/3] t: retire the sorting benchmark and mergesort helper Muhammed Dilshad A
2026-10-09 11:52   ` [PATCH v2 0/3] mergesort: move tests to Clar and retire the helper Patrick Steinhardt
2026-10-09 13:56     ` Muhammed Dilshad A
2026-10-09 15:08   ` Muhammed Dilshad A [this message]
2026-10-09 15:08     ` [PATCH v3 1/4] mergesort: move sorting tests to Clar Muhammed Dilshad A
2026-10-09 15:08     ` [PATCH v3 2/4] mergesort: simplify the unit tests Muhammed Dilshad A
2026-10-09 15:08     ` [PATCH v3 3/4] mergesort: cover empty and small lists Muhammed Dilshad A
2026-10-09 15:08     ` [PATCH v3 4/4] t: retire the sorting benchmark and mergesort helper Muhammed Dilshad A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1791556668.git.dilsheddilu123@gmail.com \
    --to=dilsheddilu123@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox