Git development
 help / color / mirror / Atom feed
From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Junio C Hamano" <gitster@pobox.com>,
	"D. Ben Knoble" <ben.knoble@gmail.com>
Cc: git@vger.kernel.org,
	"Christian Couder" <christian.couder@gmail.com>,
	jackmanb@google.com, "Linus Arver" <linus@ucla.edu>,
	"Matt Hunter" <m@lfurio.us>
Subject: Re: [PATCH v4 00/11] doc: interpret-trailers: explain key format
Date: Sat, 08 Aug 2026 22:02:47 +0200	[thread overview]
Message-ID: <d60621cd-79cb-4fac-bc0b-828e29131043@app.fastmail.com> (raw)
In-Reply-To: <xmqqldajhv9q.fsf@gitster.g>

On Thu, Aug 6, 2026, at 22:02, Junio C Hamano wrote:
> "D. Ben Knoble" <ben.knoble@gmail.com> writes:
>
>> One small comment on patch 4
>> ...
>> A few places we use an inline list syntax ("… (i) stuff … (ii) more
>> stuff …"). In the added example about ASCII trailers it is useful
>> because we make reference to (ii); in the initial part of the manual,
>> I don't see any references to the delimited items, so I'm not sure if
>> it's worth numbering them.
>>
>> Not a strong statement, though, so I'm happy either way. Everything
>> else (that I looked at, see above) looks good to me.
>
> I guess we are gettng very close to the finish line.  Kristoffer,
> how would we want to proceed?
>
> Thanks, both.

I will wait at least one day for any more comments and post a new
version with that fix that Knoble found to the commit message.

  reply	other threads:[~2026-08-08 20:03 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01 13:27 git-interpret-trailers and period characters in the key Brendan Jackman
2025-04-03 11:07 ` Christian Couder
2025-04-07 20:37   ` Junio C Hamano
2026-03-30 21:11 ` [PATCH 0/2] doc: interpret-trailers: explain key format kristofferhaugsbakk
2026-03-30 21:11   ` [PATCH 1/2] doc: interpret-trailers: stop fixating on RFC 822 kristofferhaugsbakk
2026-03-30 22:27     ` Junio C Hamano
2026-03-30 22:56       ` Kristoffer Haugsbakk
2026-03-30 23:24         ` Junio C Hamano
2026-03-30 21:11   ` [PATCH 2/2] doc: interpret-trailers: explain key format kristofferhaugsbakk
2026-03-30 21:55     ` Junio C Hamano
2026-03-30 22:23       ` Kristoffer Haugsbakk
2026-03-31 12:35         ` Ben Knoble
2026-03-31 16:03           ` Kristoffer Haugsbakk
2026-04-13 10:20   ` [PATCH v2 0/9] " kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 1/9] doc: interpret-trailers: stop fixating on RFC 822 kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 2/9] doc: interpret-trailers: replace “lines” with “metadata” kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 3/9] doc: interpret-trailers: use “metadata” in Name as well kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 4/9] doc: interpret-trailers: not just for commit messages kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 5/9] doc: interpret-trailers: explain the format after the intro kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 6/9] doc: interpret-trailers: explain key format kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 7/9] doc: interpret-trailers: add key format example kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 8/9] doc: interpret-trailers: commit to “trailer block” term kristofferhaugsbakk
2026-04-13 10:21     ` [PATCH v2 9/9] doc: intepret-trailers: document comment line treatment kristofferhaugsbakk
2026-04-13 13:26       ` Kristoffer Haugsbakk
2026-04-13 15:48         ` Junio C Hamano
2026-05-08 15:03           ` Kristoffer Haugsbakk
2026-05-08 15:01     ` [PATCH v2 0/9] doc: interpret-trailers: explain key format Kristoffer Haugsbakk
2026-05-11  2:41       ` Junio C Hamano
2026-05-11 19:23         ` D. Ben Knoble
2026-05-24 12:41           ` Kristoffer Haugsbakk
2026-05-26 21:34             ` Ben Knoble
2026-05-26 21:42               ` Kristoffer Haugsbakk
2026-05-26 21:45                 ` Kristoffer Haugsbakk
2026-06-10 21:21   ` [PATCH v3 00/11] " kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 01/11] doc: interpret-trailers: stop fixating on RFC 822 kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 02/11] doc: interpret-trailers: replace “lines” with “metadata” kristofferhaugsbakk
2026-06-11  3:10       ` Matt Hunter
2026-06-16 20:32         ` Kristoffer Haugsbakk
2026-06-16 21:39           ` Matt Hunter
2026-06-10 21:21     ` [PATCH v3 03/11] doc: interpret-trailers: use “metadata” in Name as well kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 04/11] doc: interpret-trailers: not just for commit messages kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 05/11] doc: interpret-trailers: explain the format after the intro kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 06/11] doc: interpret-trailers: explain key format kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 07/11] doc: interpret-trailers: add key format example kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 08/11] doc: interpret-trailers: join new-trailers again kristofferhaugsbakk
2026-06-10 22:00       ` D. Ben Knoble
2026-06-10 22:13         ` Kristoffer Haugsbakk
2026-06-10 21:21     ` [PATCH v3 09/11] doc: interpret-trailers: commit to “trailer block” term kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 10/11] doc: interpret-trailers: rewrite new-trailers paragraphs kristofferhaugsbakk
2026-06-10 21:21     ` [PATCH v3 11/11] doc: interpret-trailers: document comment line treatment kristofferhaugsbakk
2026-06-10 22:24     ` [PATCH v3 00/11] doc: interpret-trailers: explain key format Junio C Hamano
2026-06-11 11:57       ` Junio C Hamano
2026-06-11 12:05         ` Kristoffer Haugsbakk
2026-06-11 12:53           ` Kristoffer Haugsbakk
2026-06-17 19:45       ` Kristoffer Haugsbakk
2026-07-23 23:48         ` Junio C Hamano
2026-07-30  9:20           ` Kristoffer Haugsbakk
2026-07-30  9:18   ` [PATCH v4 " kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 01/11] doc: interpret-trailers: stop fixating on RFC 822 kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 02/11] doc: interpret-trailers: replace “lines” with “metadata” kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 03/11] doc: interpret-trailers: use “metadata” in Name as well kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 04/11] doc: interpret-trailers: not just for commit messages kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 05/11] doc: interpret-trailers: explain the format after the intro kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 06/11] doc: interpret-trailers: explain key format kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 07/11] doc: interpret-trailers: add key format example kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 08/11] doc: interpret-trailers: join new-trailers again kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 09/11] doc: interpret-trailers: commit to “trailer block” term kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 10/11] doc: interpret-trailers: rewrite new-trailers paragraphs kristofferhaugsbakk
2026-07-30  9:18     ` [PATCH v4 11/11] doc: interpret-trailers: document comment line treatment kristofferhaugsbakk
2026-08-06 11:52       ` D. Ben Knoble
2026-08-08 19:45         ` Kristoffer Haugsbakk
2026-08-06 11:55     ` [PATCH v4 00/11] doc: interpret-trailers: explain key format D. Ben Knoble
2026-08-06 20:02       ` Junio C Hamano
2026-08-08 20:02         ` Kristoffer Haugsbakk [this message]
2026-08-08 20:01       ` Kristoffer Haugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d60621cd-79cb-4fac-bc0b-828e29131043@app.fastmail.com \
    --to=kristofferhaugsbakk@fastmail.com \
    --cc=ben.knoble@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jackmanb@google.com \
    --cc=linus@ucla.edu \
    --cc=m@lfurio.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox