From: Johannes Sixt <j6t@kdbg.org>
To: Kristofer Karlsson <krka@spotify.com>
Cc: Patrick Steinhardt <ps@pks.im>,
git@vger.kernel.org,
Kristofer Karlsson via GitGitGadget <gitgitgadget@gmail.com>
Subject: Re: [PATCH 2/3] t: add "test-tool genbytes" to avoid slow tr(1) on macOS
Date: Mon, 9 Nov 2026 10:33:03 +0100 [thread overview]
Message-ID: <ddea802a-d4f4-4de9-9108-e68201841bc4@kdbg.org> (raw)
In-Reply-To: <c8688e1a-17b6-4d0b-ba9a-fc1e0fa8938b@kdbg.org>
Am 08.11.26 um 17:34 schrieb Johannes Sixt:
> Am 08.11.26 um 13:24 schrieb Kristofer Karlsson:
>> - test-tool genzeros 2147483649 | tr "\000" "1" >expect &&
>> + printf 000000000%02147483640d 0 >expect &&
>>
>> I tried this out and it works on Linux but fails on macOS[1]. What
>> happens is that printf only outputs the nine literal zeros
>> ("000000000") there, and silently ignores the very large padding.
>
> Fair enough.
>
>> [1] https://github.com/gitgitgadget/git/actions/runs/42475956442/job/128717309586
Well, this patch passed for me[2], but I have no idea whether the
particular tests were skipped due to the EXPENSIVE prerequisite or not.
[2] https://github.com/j6t/git/actions/runs/42583623620/job/129048078411
diff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats.sh
index 01b97c8888..5dedb9054e 100755
--- a/t/t4205-log-pretty-formats.sh
+++ b/t/t4205-log-pretty-formats.sh
@@ -1182,7 +1182,8 @@ unfold () {
'
test_expect_success EXPENSIVE,SIZE_T_IS_64BIT 'set up huge commit' '
- test-tool genzeros 2147483649 | tr "\000" "1" >expect &&
+ # 3 * 715827883 == 2147483649
+ printf %0715827883d 0 0 0 >expect &&
huge_commit=$(git commit-tree -F expect HEAD^{tree})
'
next prev parent reply other threads:[~2026-11-09 9:33 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 14:59 [PATCH 0/3] t: add "test-tool genbytes" to avoid slow tr(1) on macOS Kristofer Karlsson via GitGitGadget
2026-11-07 14:59 ` [PATCH 1/3] t/helper: rename test-genzeros.c to test-genbytes.c Kristofer Karlsson via GitGitGadget
2026-11-07 23:15 ` Junio C Hamano
2026-11-08 4:44 ` Junio C Hamano
2026-11-08 9:10 ` Kristofer Karlsson
2026-11-08 18:35 ` Junio C Hamano
2026-11-08 19:10 ` Kristofer Karlsson
2026-11-07 14:59 ` [PATCH 2/3] t: add "test-tool genbytes" to avoid slow tr(1) on macOS Kristofer Karlsson via GitGitGadget
2026-11-08 8:54 ` Johannes Sixt
2026-11-08 9:18 ` Kristofer Karlsson
2026-11-08 9:35 ` Johannes Sixt
2026-11-08 12:24 ` Kristofer Karlsson
2026-11-08 16:34 ` Johannes Sixt
2026-11-09 9:33 ` Johannes Sixt [this message]
2026-11-09 13:05 ` Kristofer Karlsson
2026-11-09 15:38 ` Johannes Sixt
2026-11-10 6:00 ` Collin Funk
2026-11-10 8:09 ` Kristofer Karlsson
2026-11-08 18:37 ` Junio C Hamano
2026-11-07 14:59 ` [PATCH 3/3] t: replace "test-tool genzeros" with "genbytes NUL" Kristofer Karlsson via GitGitGadget
2026-11-07 23:04 ` [PATCH 0/3] t: add "test-tool genbytes" to avoid slow tr(1) on macOS Junio C Hamano
2026-11-08 9:11 ` Kristofer Karlsson
2026-11-07 23:23 ` Junio C Hamano
2026-11-08 9:13 ` Kristofer Karlsson
2026-11-08 19:15 ` [PATCH v2 0/2] " Kristofer Karlsson via GitGitGadget
2026-11-08 19:15 ` [PATCH v2 1/2] " Kristofer Karlsson via GitGitGadget
2026-11-09 1:39 ` Junio C Hamano
2026-11-09 7:10 ` Kristofer Karlsson
2026-11-09 15:41 ` Junio C Hamano
2026-11-09 6:59 ` Patrick Steinhardt
2026-11-09 7:43 ` Kristofer Karlsson
2026-11-08 19:15 ` [PATCH v2 2/2] t: replace "test-tool genzeros" with "genbytes 00" Kristofer Karlsson via GitGitGadget
2026-11-10 18:26 ` [PATCH v3] t: add "test-tool genbytes" to avoid slow tr(1) on macOS Kristofer Karlsson via GitGitGadget
2026-11-10 19:31 ` Junio C Hamano
2026-11-11 10:54 ` Patrick Steinhardt
2026-11-11 15:38 ` Junio C Hamano
2026-11-11 15:47 ` Kristofer Karlsson
2026-11-11 17:57 ` Junio C Hamano
2026-11-11 15:59 ` [PATCH v4] " Kristofer Karlsson via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddea802a-d4f4-4de9-9108-e68201841bc4@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=krka@spotify.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox