Re: [PATCH 1/3] t/helper: rename test-genzeros.c to test-genbytes.c

[Junio C Hamano <gitster@pobox.com>]

Junio C Hamano <gitster@pobox.com> writes:

> Needless to say, with this patch applied, the following tests would
> now fail, unable to find "test-tool genzeros".

Not really.  Even though the source file is renamed, the dispatcher
inside still recognises genzeros and calls cmd__genzeros.  In fact,
at this stage, "test-tool genbytes" would not even work (and it does
not have to work as nobody calls it).

So, sorry for the false alarm, but my point about not split the
rename + modification into two separate steps still stands.

Thanks.

>
>     t0613-reftable-write-options.sh
>     t1007-hash-object.sh
>     t1051-large-conversion.sh
>     t1450-fsck.sh
>     t4141-apply-too-large.sh
>     t4205-log-pretty-formats.sh
>     t5300-pack-object.sh
>     t5318-commit-graph.sh
>     t7006-pager.sh
>     t9850-shell.sh
>
> FWIW, if you apply [1/3] and [2/3], squash them together, then give
> a custom rename factor to the command, e.g.,
>
>     $ git format-patch -M3 -1
>
> to format the resulting single patch, you will see a modification of
> genzeros while the file gets renamed just fine, and you would not
> have to break these tests in the middle of a series.