* [PATCH] parse-options: drop unused parse_opt_ctx_t member
@ 2023-10-03 8:55 René Scharfe
2023-10-03 17:38 ` Eric Sunshine
0 siblings, 1 reply; 3+ messages in thread
From: René Scharfe @ 2023-10-03 8:55 UTC (permalink / raw)
To: Git List
5c387428f1 (parse-options: don't emit "ambiguous option" for aliases,
2019-04-29) added "updated_options" to struct parse_opt_ctx_t, but it
has never been used. Remove it.
---
parse-options.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/parse-options.h b/parse-options.h
index 57a7fe9d91..4a66ec3bf5 100644
--- a/parse-options.h
+++ b/parse-options.h
@@ -459,7 +459,6 @@ struct parse_opt_ctx_t {
unsigned has_subcommands;
const char *prefix;
const char **alias_groups; /* must be in groups of 3 elements! */
- struct option *updated_options;
};
void parse_options_start(struct parse_opt_ctx_t *ctx,
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] parse-options: drop unused parse_opt_ctx_t member
2023-10-03 8:55 [PATCH] parse-options: drop unused parse_opt_ctx_t member René Scharfe
@ 2023-10-03 17:38 ` Eric Sunshine
2023-10-03 18:00 ` René Scharfe
0 siblings, 1 reply; 3+ messages in thread
From: Eric Sunshine @ 2023-10-03 17:38 UTC (permalink / raw)
To: René Scharfe; +Cc: Git List
On Tue, Oct 3, 2023 at 4:55 AM René Scharfe <l.s.r@web.de> wrote:
> 5c387428f1 (parse-options: don't emit "ambiguous option" for aliases,
> 2019-04-29) added "updated_options" to struct parse_opt_ctx_t, but it
> has never been used. Remove it.
> ---
Missing sign-off.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] parse-options: drop unused parse_opt_ctx_t member
2023-10-03 17:38 ` Eric Sunshine
@ 2023-10-03 18:00 ` René Scharfe
0 siblings, 0 replies; 3+ messages in thread
From: René Scharfe @ 2023-10-03 18:00 UTC (permalink / raw)
To: Eric Sunshine; +Cc: Git List
Am 03.10.23 um 19:38 schrieb Eric Sunshine:
> On Tue, Oct 3, 2023 at 4:55 AM René Scharfe <l.s.r@web.de> wrote:
>> 5c387428f1 (parse-options: don't emit "ambiguous option" for aliases,
>> 2019-04-29) added "updated_options" to struct parse_opt_ctx_t, but it
>> has never been used. Remove it.
>> ---
>
> Missing sign-off.
Oops, thanks for catching that. Technically not necessary, I guess,
since the patch is trivial, but here it is:
Signed-off-by: René Scharfe <l.s.r@web.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-03 18:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-03 8:55 [PATCH] parse-options: drop unused parse_opt_ctx_t member René Scharfe
2023-10-03 17:38 ` Eric Sunshine
2023-10-03 18:00 ` René Scharfe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox