Git development
 help / color / mirror / Atom feed
* git-tag -s can't find GPG private key
@ 2010-01-27 21:02 Mike.lifeguard
  2010-01-27 21:06 ` Sverre Rabbelier
  2010-01-27 21:16 ` Junio C Hamano
  0 siblings, 2 replies; 3+ messages in thread
From: Mike.lifeguard @ 2010-01-27 21:02 UTC (permalink / raw)
  To: git

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

It seems that when the GPG key name and user.name in git's config are
different, git can't find the appropriate private key to sign the tag.
Git should attempt to use user.email to find the key. Setting
user.signingkey is of course a workaround. The relevant code would be in
builtin-tag.c.

- -Mike
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAktgqewACgkQst0AR/DaKHuDZgCgpYHD05aJHKF/Wj/uU8CK5swP
SccAoMjHVKM/OZBhbvSvC+aWCQ123Tje
=ZIo0
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: git-tag -s can't find GPG private key
  2010-01-27 21:02 git-tag -s can't find GPG private key Mike.lifeguard
@ 2010-01-27 21:06 ` Sverre Rabbelier
  2010-01-27 21:16 ` Junio C Hamano
  1 sibling, 0 replies; 3+ messages in thread
From: Sverre Rabbelier @ 2010-01-27 21:06 UTC (permalink / raw)
  To: Mike.lifeguard; +Cc: git

Heya,

On Wed, Jan 27, 2010 at 22:02, Mike.lifeguard <mike.lifeguard@gmail.com> wrote:
> It seems that when the GPG key name and user.name in git's config are
> different, git can't find the appropriate private key to sign the tag.
> Git should attempt to use user.email to find the key. Setting
> user.signingkey is of course a workaround. The relevant code would be in
> builtin-tag.c.

It seems you already know where to look, why don't you try and come up
with a patch since it is indeed, your itch to scratch?

-- 
Cheers,

Sverre Rabbelier

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: git-tag -s can't find GPG private key
  2010-01-27 21:02 git-tag -s can't find GPG private key Mike.lifeguard
  2010-01-27 21:06 ` Sverre Rabbelier
@ 2010-01-27 21:16 ` Junio C Hamano
  1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2010-01-27 21:16 UTC (permalink / raw)
  To: Mike.lifeguard; +Cc: git

"Mike.lifeguard" <mike.lifeguard@gmail.com> writes:

> It seems that when the GPG key name and user.name in git's config are
> different, git can't find the appropriate private key to sign the tag.
> Git should attempt to use user.email to find the key. Setting
> user.signingkey is of course a workaround.

user.signingkey was devised for this exact case, and I don't think it is a
work-around.

I do not think "should attempt" is a correct attitude, even though I can
100% agree with "it would have been nicer if it attempted to do this from
day one".  You are unfortunately not interacting with git codebase in
early 2005 anymore and there are thousands if not millions of existing
users you should worry about.

Using user.email changes the behaviour for people who do not want a key
that has the same e-mail address, and because the choice of key is all
about security, the logic to choose which one shouldn't be changed
lightly.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-01-27 21:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-27 21:02 git-tag -s can't find GPG private key Mike.lifeguard
2010-01-27 21:06 ` Sverre Rabbelier
2010-01-27 21:16 ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox