* [PATCH 2/6] ident.c: Disambiguate the error messages in setup_ident
@ 2005-07-15 0:52 Eric W. Biederman
[not found] ` <7vr7e03m4k.fsf@assigned-by-dhcp.cox.net>
0 siblings, 1 reply; 2+ messages in thread
From: Eric W. Biederman @ 2005-07-15 0:52 UTC (permalink / raw)
To: Linus Torvalds; +Cc: git
If your user name is too long it is your sysadmin who
hates you not your parents!
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
ident.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
935f88376b79fc19df6dff85ba57ed94f06d79f0
diff --git a/ident.c b/ident.c
--- a/ident.c
+++ b/ident.c
@@ -26,13 +26,13 @@ int setup_ident(void)
/* Get the name ("gecos") */
len = strlen(pw->pw_gecos);
if (len >= sizeof(real_name))
- die("Your parents must have hated you");
+ die("Your parents must have hated you!");
memcpy(real_name, pw->pw_gecos, len+1);
/* Make up a fake email address (name + '@' + hostname [+ '.' + domainname]) */
len = strlen(pw->pw_name);
if (len > sizeof(real_email)/2)
- die("Your parents must have hated you");
+ die("Your sysadmin must have hate you!");
memcpy(real_email, pw->pw_name, len);
real_email[len++] = '@';
gethostname(real_email + len, sizeof(real_email) - len);
^ permalink raw reply [flat|nested] 2+ messages in thread[parent not found: <7vr7e03m4k.fsf@assigned-by-dhcp.cox.net>]
[parent not found: <m1br54x324.fsf@ebiederm.dsl.xmission.com>]
[parent not found: <7v8y083k5o.fsf@assigned-by-dhcp.cox.net>]
* [PATCH] Complain about sysadmins in the present tense. [not found] ` <7v8y083k5o.fsf@assigned-by-dhcp.cox.net> @ 2005-07-15 2:10 ` Eric W. Biederman 0 siblings, 0 replies; 2+ messages in thread From: Eric W. Biederman @ 2005-07-15 2:10 UTC (permalink / raw) To: Linus Torvalds; +Cc: git Junio C Hamano <junkio@cox.net> writes: > ebiederm@xmission.com (Eric W. Biederman) writes: > >> Actually I could not see something the system administrator >> had bone being anything but present tense. If you have to type >> 500+ characters just to login, I think you would have noticed >> and complained to your sysadmin earlier... > > I think "must have hate you" is simply an incorrect grammar, not > present tense. You mean "must hate you", perhaps? Yes. It looks like I failed to delete the have :( Somethings you just can't see when you know what you meant. Here is a patch to fix it up. Eric Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> --- Documentation/git-commit-tree.txt | 2 +- Documentation/git-var.txt | 2 +- ident.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) 554595e307653e90e5945bcef739fde935d7bcef diff --git a/Documentation/git-commit-tree.txt b/Documentation/git-commit-tree.txt --- a/Documentation/git-commit-tree.txt +++ b/Documentation/git-commit-tree.txt @@ -70,7 +70,7 @@ You don't exist. Go away!:: The passwd(5) gecos field couldn't be read Your parents must have hated you!:: The password(5) gecos field is longer than a giant static buffer. -Your sysadmin must have hate you!:: +Your sysadmin must hate you!:: The password(5) name field is longer than a giant static buffer. See Also diff --git a/Documentation/git-var.txt b/Documentation/git-var.txt --- a/Documentation/git-var.txt +++ b/Documentation/git-var.txt @@ -38,7 +38,7 @@ You don't exist. Go away!:: The passwd(5) gecos field couldn't be read Your parents must have hated you!:: The password(5) gecos field is longer than a giant static buffer. -Your sysadmin must have hate you!:: +Your sysadmin must hate you!:: The password(5) name field is longer than a giant static buffer. See Also diff --git a/ident.c b/ident.c --- a/ident.c +++ b/ident.c @@ -32,7 +32,7 @@ int setup_ident(void) /* Make up a fake email address (name + '@' + hostname [+ '.' + domainname]) */ len = strlen(pw->pw_name); if (len > sizeof(real_email)/2) - die("Your sysadmin must have hate you!"); + die("Your sysadmin must hate you!"); memcpy(real_email, pw->pw_name, len); real_email[len++] = '@'; gethostname(real_email + len, sizeof(real_email) - len); ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-07-15 2:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-15 0:52 [PATCH 2/6] ident.c: Disambiguate the error messages in setup_ident Eric W. Biederman
[not found] ` <7vr7e03m4k.fsf@assigned-by-dhcp.cox.net>
[not found] ` <m1br54x324.fsf@ebiederm.dsl.xmission.com>
[not found] ` <7v8y083k5o.fsf@assigned-by-dhcp.cox.net>
2005-07-15 2:10 ` [PATCH] Complain about sysadmins in the present tense Eric W. Biederman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox