[PATCH v2] ci: drop no-op gettext link on macOS

["Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com>]

From: Harald Nordgren <haraldnordgren@gmail.com>

Homebrew's gettext formula used to be keg-only, meaning brew would
install it into the Cellar without linking its headers, libraries, or
utilities like msgfmt anywhere on the default search paths, to avoid
clashing with software that already ships its own gettext. `brew link
--force gettext` overrode that restriction so the keg-only install
became visible on the paths git's build and tests rely on.

Homebrew dropped gettext's keg-only status in 2020
(https://github.com/Homebrew/homebrew-core/pull/53489), so a fresh
install now links into the prefix by itself. `brew link --force`
against an already-linked keg has nothing left to override, and only
produces a spurious "Already linked" warning in every macOS job's
log.

Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
---
    ci: drop no-op gettext link on macOS
    
    Gettext is already linked on the macOS CI runner image, so the forced
    relink was a no-op that only produced a spurious "Already linked"
    warning in every macOS job's log.
    
    Changes in v2:
    
     * Clarify problem in commit message.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2402%2FHaraldNordgren%2Fci-drop-noop-gettext-link-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2402/HaraldNordgren/ci-drop-noop-gettext-link-v2
Pull-Request: https://github.com/git/git/pull/2402

Range-diff vs v1:

 1:  9af619d085 ! 1:  39922c8e97 ci: drop no-op gettext link on macOS
     @@ Metadata
       ## Commit message ##
          ci: drop no-op gettext link on macOS
      
     -    gettext ships already linked on the macOS CI runner image, so this
     -    command never links anything. It only emits a spurious "Already
     -    linked" warning in every macOS job's log.
     +    Homebrew's gettext formula used to be keg-only, meaning brew would
     +    install it into the Cellar without linking its headers, libraries, or
     +    utilities like msgfmt anywhere on the default search paths, to avoid
     +    clashing with software that already ships its own gettext. `brew link
     +    --force gettext` overrode that restriction so the keg-only install
     +    became visible on the paths git's build and tests rely on.
     +
     +    Homebrew dropped gettext's keg-only status in 2020
     +    (https://github.com/Homebrew/homebrew-core/pull/53489), so a fresh
     +    install now links into the prefix by itself. `brew link --force`
     +    against an already-linked keg has nothing left to override, and only
     +    produces a spurious "Already linked" warning in every macOS job's
     +    log.
      
          Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
      


 ci/install-dependencies.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
index 2f61fbb07c..2903c39fab 100755
--- a/ci/install-dependencies.sh
+++ b/ci/install-dependencies.sh
@@ -117,7 +117,6 @@ macos-*)
 	export HOMEBREW_NO_AUTO_UPDATE=1 HOMEBREW_NO_INSTALL_CLEANUP=1
 	# Uncomment this if you want to run perf tests:
 	# brew install gnu-time
-	brew link --force gettext
 
 	mkdir -p "$CUSTOM_PATH"
 	wget -q "$P4WHENCE/bin.macosx12arm64/helix-core-server.tgz" &&

base-commit: 47ce80527c56f462cb97db4ca8125342204d3783
-- 
gitgitgadget