Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Harald Nordgren <haraldnordgren@gmail.com>
Subject: Re: [PATCH v2] ci: drop no-op gettext link on macOS
Date: Fri, 25 Sep 2026 21:36:56 -0700	[thread overview]
Message-ID: <xmqqik3ssk5z.fsf@gitster.g> (raw)
In-Reply-To: <pull.2402.v2.git.git.1789369749450.gitgitgadget@gmail.com> (Harald Nordgren via GitGitGadget's message of "Mon, 14 Sep 2026 07:09:09 +0000")

"Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Harald Nordgren <haraldnordgren@gmail.com>
>
> Homebrew's gettext formula used to be keg-only, meaning brew would
> install it into the Cellar without linking its headers, libraries, or
> utilities like msgfmt anywhere on the default search paths, to avoid
> clashing with software that already ships its own gettext. `brew link
> --force gettext` overrode that restriction so the keg-only install
> became visible on the paths git's build and tests rely on.
>
> Homebrew dropped gettext's keg-only status in 2020
> (https://github.com/Homebrew/homebrew-core/pull/53489), so a fresh
> install now links into the prefix by itself. `brew link --force`
> against an already-linked keg has nothing left to override, and only
> produces a spurious "Already linked" warning in every macOS job's
> log.
>
> Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
> ---

Sorry, but I lost track.  There were review exchanges on the
previous round, which crossed with this new iteration.  Is this
patch still relevant and do folks on macOS need this?

Thanks.

  reply	other threads:[~2026-09-26  4:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-12  7:55 [PATCH] ci: drop no-op gettext link on macOS Harald Nordgren via GitGitGadget
2026-09-14  6:25 ` Patrick Steinhardt
2026-09-14  6:57   ` Harald Nordgren
2026-09-14  7:53     ` Patrick Steinhardt
2026-09-14  8:50       ` Harald Nordgren
2026-09-14  7:09 ` [PATCH v2] " Harald Nordgren via GitGitGadget
2026-09-26  4:36   ` Junio C Hamano [this message]
2026-09-26 13:33     ` Harald Nordgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqik3ssk5z.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=haraldnordgren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox