Git development
 help / color / mirror / Atom feed
* [PATCH] lazyload: fix typo in comment
@ 2026-11-21 15:44 Ophir Bleicher via GitGitGadget
  2026-11-21 16:04 ` Johannes Schindelin
  0 siblings, 1 reply; 2+ messages in thread
From: Ophir Bleicher via GitGitGadget @ 2026-11-21 15:44 UTC (permalink / raw)
  To: git; +Cc: Ophir Bleicher, Ophir Bleicher

From: Ophir Bleicher <ophirble@gmail.com>

Fix a typo on line 11 of compat/win32/lazyload.h, inside a comment.
That comment shows an example of function usage, without a closing
parentheses:

return error("Could not find CreateHardLinkW() function";

There isn't any closing ')'.

Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
---
    lazyload: fix typo in comment

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2497%2FOphirBleicher%2Ffix-typo-lazyload-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2497/OphirBleicher/fix-typo-lazyload-v1
Pull-Request: https://github.com/git/git/pull/2497

 compat/win32/lazyload.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compat/win32/lazyload.h b/compat/win32/lazyload.h
index f2bb96c89c..d348a89f9b 100644
--- a/compat/win32/lazyload.h
+++ b/compat/win32/lazyload.h
@@ -8,7 +8,7 @@
  *                     LPCWSTR, LPCWSTR, LPSECURITY_ATTRIBUTES);
  *
  *   if (!INIT_PROC_ADDR(CreateHardLinkW))
- *           return error("Could not find CreateHardLinkW() function";
+ *           return error("Could not find CreateHardLinkW() function");
  *
  *   if (!CreateHardLinkW(source, target, NULL))
  *           return error("could not create hardlink from %S to %S",

base-commit: f7de81456940dd6f3274e461149bba12965de609
-- 
gitgitgadget

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] lazyload: fix typo in comment
  2026-11-21 15:44 [PATCH] lazyload: fix typo in comment Ophir Bleicher via GitGitGadget
@ 2026-11-21 16:04 ` Johannes Schindelin
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Schindelin @ 2026-11-21 16:04 UTC (permalink / raw)
  To: Ophir Bleicher via GitGitGadget; +Cc: git, Ophir Bleicher, Ophir Bleicher

Hi Ophir,

On Sat, 21 Nov 2026, Ophir Bleicher via GitGitGadget wrote:

> From: Ophir Bleicher <ophirble@gmail.com>
> 
> Fix a typo on line 11 of compat/win32/lazyload.h, inside a comment.
> That comment shows an example of function usage, without a closing
> parentheses:
> 
> return error("Could not find CreateHardLinkW() function";
> 
> There isn't any closing ')'.

Yes, this was incorrect, and your fix is much appreciated.

Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Thank you,
Johannes

> 
> Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
> ---
>     lazyload: fix typo in comment
> 
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2497%2FOphirBleicher%2Ffix-typo-lazyload-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2497/OphirBleicher/fix-typo-lazyload-v1
> Pull-Request: https://github.com/git/git/pull/2497
> 
>  compat/win32/lazyload.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/compat/win32/lazyload.h b/compat/win32/lazyload.h
> index f2bb96c89c..d348a89f9b 100644
> --- a/compat/win32/lazyload.h
> +++ b/compat/win32/lazyload.h
> @@ -8,7 +8,7 @@
>   *                     LPCWSTR, LPCWSTR, LPSECURITY_ATTRIBUTES);
>   *
>   *   if (!INIT_PROC_ADDR(CreateHardLinkW))
> - *           return error("Could not find CreateHardLinkW() function";
> + *           return error("Could not find CreateHardLinkW() function");
>   *
>   *   if (!CreateHardLinkW(source, target, NULL))
>   *           return error("could not create hardlink from %S to %S",
> 
> base-commit: f7de81456940dd6f3274e461149bba12965de609
> -- 
> gitgitgadget
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-21 16:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-21 15:44 [PATCH] lazyload: fix typo in comment Ophir Bleicher via GitGitGadget
2026-11-21 16:04 ` Johannes Schindelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox