From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: "Guillaume Pagès" <guillaume.pages@ensimag.grenoble-inp.fr>
Cc: git@vger.kernel.org,
Remi Galan <remi.galan-alfonso@ensimag.grenoble-inp.fr>,
Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr>,
Louis-Alexandre Stuber
<louis--alexandre.stuber@ensimag.grenoble-inp.fr>,
Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr>
Subject: Re: [RFC/PATCH 1/2] status: give more information during rebase -i
Date: Wed, 03 Jun 2015 19:20:16 +0200 [thread overview]
Message-ID: <vpqh9qobtf3.fsf@anie.imag.fr> (raw)
In-Reply-To: <1433320545-14244-1-git-send-email-guillaume.pages@ensimag.grenoble-inp.fr> ("Guillaume \=\?iso-8859-1\?Q\?Pag\=E8s\=22's\?\= message of "Wed, 3 Jun 2015 10:35:44 +0200")
Guillaume Pagès <guillaume.pages@ensimag.grenoble-inp.fr> writes:
> + if (!fclose(fp))
> + strbuf_detach(&buf, NULL);
> + else
> + strbuf_release(&buf);
Why these two cases? Aren't you leaking the buffer when calling
strbuf_detach and ignoring its return value?
(In general, there's not much to do when fclose fails actually)
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
prev parent reply other threads:[~2015-06-03 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 8:35 [RFC/PATCH 1/2] status: give more information during rebase -i Guillaume Pagès
2015-06-03 8:35 ` [RFC/PATCH 2/2] status: fix tests to handle new verbose git status during rebase Guillaume Pagès
2015-06-03 17:42 ` Matthieu Moy
2015-06-03 18:25 ` Junio C Hamano
2015-06-03 19:51 ` Guillaume Pages
2015-06-03 17:12 ` [RFC/PATCH 1/2] status: give more information during rebase -i Matthieu Moy
2015-06-03 17:20 ` Matthieu Moy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqh9qobtf3.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=antoine.delaite@ensimag.grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=guillaume.pages@ensimag.grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag.grenoble-inp.fr \
--cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox