Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: "Guillaume Pagès" <guillaume.pages@ensimag.grenoble-inp.fr>,
	git@vger.kernel.org,
	"Remi Galan" <remi.galan-alfonso@ensimag.grenoble-inp.fr>,
	"Remi Lespinet" <remi.lespinet@ensimag.grenoble-inp.fr>,
	"Louis-Alexandre Stuber"
	<louis--alexandre.stuber@ensimag.grenoble-inp.fr>,
	"Antoine Delaite" <antoine.delaite@ensimag.grenoble-inp.fr>
Subject: Re: [RFC/PATCH 2/2] status: fix tests to handle new verbose git status during rebase
Date: Wed, 03 Jun 2015 11:25:38 -0700	[thread overview]
Message-ID: <xmqqvbf4wswt.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpqmw0gadth.fsf@anie.imag.fr> (Matthieu Moy's message of "Wed, 03 Jun 2015 19:42:34 +0200")

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Guillaume Pagès <guillaume.pages@ensimag.grenoble-inp.fr> writes:
>
>> Signed-off-by: Guillaume Pagès <guillaume.pages@ensimag.grenoble-inp.fr>
>> ---
>>  t/t7512-status-help.sh | 227 ++++++++++++++++++++++++++++++++++++++++++++++---
>
> Your history is not bisectable if you sparate tests and code changes in
> two patches.

Yes.

And by squashing the two, you do not have to label 2/2 incorrectly
as "fix tests"; it is merely fixing what 1/2 broke ;-)

> Plus, as a reviewer, I like seeing changes to the tests next to changes
> to the code, to show me what is the impact of the code change on the
> output of the program.

That too. is a very important consideration, maybe even more so than
bisectability.

Thanks.

  reply	other threads:[~2015-06-03 18:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03  8:35 [RFC/PATCH 1/2] status: give more information during rebase -i Guillaume Pagès
2015-06-03  8:35 ` [RFC/PATCH 2/2] status: fix tests to handle new verbose git status during rebase Guillaume Pagès
2015-06-03 17:42   ` Matthieu Moy
2015-06-03 18:25     ` Junio C Hamano [this message]
2015-06-03 19:51       ` Guillaume Pages
2015-06-03 17:12 ` [RFC/PATCH 1/2] status: give more information during rebase -i Matthieu Moy
2015-06-03 17:20 ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqvbf4wswt.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=antoine.delaite@ensimag.grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=guillaume.pages@ensimag.grenoble-inp.fr \
    --cc=louis--alexandre.stuber@ensimag.grenoble-inp.fr \
    --cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
    --cc=remi.lespinet@ensimag.grenoble-inp.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox