From: Junio C Hamano <gitster@pobox.com>
To: Cynthia Uche <herroyalpriestess@gmail.com>
Cc: git@vger.kernel.org, l.s.r@web.de, christian.couder@gmail.com,
siddharthasthana31@gmail.com, kaartic.sivaraam@gmail.com,
usmanakinyemi202@gmail.com
Subject: Re: [Outreachy PATCH] api-parse-options.adoc: restore a dropped word
Date: Wed, 04 Nov 2026 15:13:22 -0800 [thread overview]
Message-ID: <xmqq1p90yyul.fsf@gitster.g> (raw)
In-Reply-To: <20261104224559.4197-1-herroyalpriestess@gmail.com> (Cynthia Uche's message of "Wed, 4 Nov 2026 23:45:59 +0100")
Cynthia Uche <herroyalpriestess@gmail.com> writes:
> The description of PARSE_OPT_KEEP_UNKNOWN_OPT ends with "..., the
> parser early.", which is not a sentence. The word "stopping" was lost
> in 0d260f9a09 (parseopt: prevent KEEP_UNKNOWN and STOP_AT_NON_OPTION
> from being used together, 2009-03-09), which rewrote the end of that
> sentence.
Makes sense. Thanks for finding and fixing.
>
> Restore it, and rewrap the following line.
>
> Signed-off-by: Cynthia Uche <herroyalpriestess@gmail.com>
> ---
> Documentation/technical/api-parse-options.adoc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/technical/api-parse-options.adoc b/Documentation/technical/api-parse-options.adoc
> index 6dfea34220..14f0d2b572 100644
> --- a/Documentation/technical/api-parse-options.adoc
> +++ b/Documentation/technical/api-parse-options.adoc
> @@ -127,8 +127,8 @@ Flags are the bitwise-or of:
> `PARSE_OPT_STOP_AT_NON_OPTION` is set, the second argument in
> `--unknown value` will be mistakenly interpreted as a
> non-option, not as a value belonging to the unknown option,
> - the parser early. That's why parse_options() errors out if
> - both options are set.
> + stopping the parser early. That's why parse_options() errors
> + out if both options are set.
> Note that non-option arguments are always kept, even without
> this flag.
prev parent reply other threads:[~2026-11-04 23:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 22:45 [Outreachy PATCH] api-parse-options.adoc: restore a dropped word Cynthia Uche
2026-11-04 23:13 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1p90yyul.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=herroyalpriestess@gmail.com \
--cc=kaartic.sivaraam@gmail.com \
--cc=l.s.r@web.de \
--cc=siddharthasthana31@gmail.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox