* [Outreachy PATCH] api-parse-options.adoc: restore a dropped word
@ 2026-11-04 22:45 Cynthia Uche
2026-11-04 23:13 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Cynthia Uche @ 2026-11-04 22:45 UTC (permalink / raw)
To: git
Cc: gitster, l.s.r, christian.couder, siddharthasthana31,
kaartic.sivaraam, usmanakinyemi202
The description of PARSE_OPT_KEEP_UNKNOWN_OPT ends with "..., the
parser early.", which is not a sentence. The word "stopping" was lost
in 0d260f9a09 (parseopt: prevent KEEP_UNKNOWN and STOP_AT_NON_OPTION
from being used together, 2009-03-09), which rewrote the end of that
sentence.
Restore it, and rewrap the following line.
Signed-off-by: Cynthia Uche <herroyalpriestess@gmail.com>
---
Documentation/technical/api-parse-options.adoc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/technical/api-parse-options.adoc b/Documentation/technical/api-parse-options.adoc
index 6dfea34220..14f0d2b572 100644
--- a/Documentation/technical/api-parse-options.adoc
+++ b/Documentation/technical/api-parse-options.adoc
@@ -127,8 +127,8 @@ Flags are the bitwise-or of:
`PARSE_OPT_STOP_AT_NON_OPTION` is set, the second argument in
`--unknown value` will be mistakenly interpreted as a
non-option, not as a value belonging to the unknown option,
- the parser early. That's why parse_options() errors out if
- both options are set.
+ stopping the parser early. That's why parse_options() errors
+ out if both options are set.
Note that non-option arguments are always kept, even without
this flag.
--
2.56.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy PATCH] api-parse-options.adoc: restore a dropped word
2026-11-04 22:45 [Outreachy PATCH] api-parse-options.adoc: restore a dropped word Cynthia Uche
@ 2026-11-04 23:13 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2026-11-04 23:13 UTC (permalink / raw)
To: Cynthia Uche
Cc: git, l.s.r, christian.couder, siddharthasthana31,
kaartic.sivaraam, usmanakinyemi202
Cynthia Uche <herroyalpriestess@gmail.com> writes:
> The description of PARSE_OPT_KEEP_UNKNOWN_OPT ends with "..., the
> parser early.", which is not a sentence. The word "stopping" was lost
> in 0d260f9a09 (parseopt: prevent KEEP_UNKNOWN and STOP_AT_NON_OPTION
> from being used together, 2009-03-09), which rewrote the end of that
> sentence.
Makes sense. Thanks for finding and fixing.
>
> Restore it, and rewrap the following line.
>
> Signed-off-by: Cynthia Uche <herroyalpriestess@gmail.com>
> ---
> Documentation/technical/api-parse-options.adoc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/technical/api-parse-options.adoc b/Documentation/technical/api-parse-options.adoc
> index 6dfea34220..14f0d2b572 100644
> --- a/Documentation/technical/api-parse-options.adoc
> +++ b/Documentation/technical/api-parse-options.adoc
> @@ -127,8 +127,8 @@ Flags are the bitwise-or of:
> `PARSE_OPT_STOP_AT_NON_OPTION` is set, the second argument in
> `--unknown value` will be mistakenly interpreted as a
> non-option, not as a value belonging to the unknown option,
> - the parser early. That's why parse_options() errors out if
> - both options are set.
> + stopping the parser early. That's why parse_options() errors
> + out if both options are set.
> Note that non-option arguments are always kept, even without
> this flag.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-04 23:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-04 22:45 [Outreachy PATCH] api-parse-options.adoc: restore a dropped word Cynthia Uche
2026-11-04 23:13 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox