From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: "Christian Noé Ramos López" <chris@nortesoftware.dev>,
git@vger.kernel.org, "Phillip Wood" <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH] doc: gpg: say which date SSH key lifetimes are checked against
Date: Thu, 22 Oct 2026 09:45:51 -0700 [thread overview]
Message-ID: <xmqq1p9hiszk.fsf@gitster.g> (raw)
In-Reply-To: <atmsSIJrFhA0t1rH@pks.im> (Patrick Steinhardt's message of "Thu, 22 Oct 2026 08:25:12 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> I think explicitly pointing out that the timestamp is under control by
> the signer would be useful context though. It's implicit to us, but it
> may not be implicit to everyone else. So maybe something like this?
>
> Since OpensSSH 8.8 this file allows specifying a key lifetime using
> valid-after & valid-before options. Git validates the signature by
> checking the committer or tagger timestamp is within the validity
> time range. This does not provide any security guarantees as the
> timestamp can be chosen arbitrarily by the signer. But it allows
> users to change a signing key without invalidating all previously
> made signatures.
Sounds sensible. Thanks.
next prev parent reply other threads:[~2026-10-22 16:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 6:56 ssh signing: valid-before is checked at the signer's own date, and a missing revocationFile fails open Christian Noé Ramos López
2026-10-08 13:42 ` Phillip Wood
2026-10-09 12:19 ` Patrick Steinhardt
2026-10-09 13:30 ` Phillip Wood
[not found] ` <CAHGSfba9Td+Lg=Nf+nfwZY2r1_eq2Mcejn__6X=VPQkmcJttfQ@mail.gmail.com>
2026-10-09 13:29 ` Phillip Wood
2026-10-21 3:03 ` [PATCH] doc: gpg: say which date SSH key lifetimes are checked against Christian Noé Ramos López
2026-10-21 18:14 ` Junio C Hamano
2026-10-22 5:44 ` [PATCH v2] " Christian Noé Ramos López
2026-10-22 6:25 ` [PATCH] " Patrick Steinhardt
2026-10-22 16:45 ` Junio C Hamano [this message]
2026-10-21 4:17 ` [PATCH] gpg-interface: fail when the ssh revocation file is missing Christian Noé Ramos López
2026-10-21 18:40 ` Junio C Hamano
2026-10-22 5:46 ` [PATCH v2] " Christian Noé Ramos López
2026-10-22 15:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1p9hiszk.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chris@nortesoftware.dev \
--cc=git@vger.kernel.org \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox