* [PATCH] CodingGuidelines: !! is not all that exotic
@ 2026-11-18 18:31 Junio C Hamano
0 siblings, 0 replies; only message in thread
From: Junio C Hamano @ 2026-11-18 18:31 UTC (permalink / raw)
To: git
Remove the clause against "clever tricks" that cites !!value that is
a standard technique to normalize a value to 0/1 boolean. We could
resurrect it if we can come up with a truly exotic example that we
would want to avoid, but this is not a good enough justification for
this rule.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
* I think we saw a good example that !! was used in a recent review
thread, and the idea to remove this rule was floated back then,
but without following through.
Documentation/CodingGuidelines | 4 ----
1 file changed, 4 deletions(-)
diff --git c/Documentation/CodingGuidelines w/Documentation/CodingGuidelines
index 3c8d6c7dd3..4bfa615bac 100644
--- c/Documentation/CodingGuidelines
+++ w/Documentation/CodingGuidelines
@@ -522,10 +522,6 @@ For C programs:
that_is_used_in + a_very_long_expression) {
...
- - Some clever tricks, like using the !! operator with arithmetic
- constructs, can be extremely confusing to others. Avoid them,
- unless there is a compelling reason to use them.
-
- Use the API. No, really. We have a strbuf (variable length
string), several arrays with the ALLOC_GROW() macro, a
string_list for sorted string lists, a hash map (mapping struct
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-18 18:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 18:31 [PATCH] CodingGuidelines: !! is not all that exotic Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox