Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Usman Akinyemi <usmanakinyemi202@gmail.com>
Cc: christian.couder@gmail.com,  git@vger.kernel.org,
	 me@ttaylorr.com, phillip.wood123@gmail.com,  ps@pks.im
Subject: Re: [RFC PATCH v3 0/2] push: add support for pushing to remote groups
Date: Tue, 28 Apr 2026 10:47:14 +0900	[thread overview]
Message-ID: <xmqq340f26vx.fsf@gitster.g> (raw)
In-Reply-To: <20260427140530.856125-1-usmanakinyemi202@gmail.com> (Usman Akinyemi's message of "Mon, 27 Apr 2026 19:35:28 +0530")

Something like this is needed to workaround -Werror=sign-compare complaints.

diff --git a/builtin/push.c b/builtin/push.c
index 10384f265c..6021b71d66 100644
--- a/builtin/push.c
+++ b/builtin/push.c
@@ -552,7 +552,8 @@ static int push_multiple(struct string_list *list,
 			 const char **refspecs,
 			 int refspec_nr)
 {
-	int i, result = 0;
+	int result = 0;
+	size_t i;
 	struct strvec argv = STRVEC_INIT;
 
 	strvec_push(&argv, "push");
diff --git a/remote.h b/remote.h
index 8ff2bd88fa..7915be3111 100644
--- a/remote.h
+++ b/remote.h
@@ -430,8 +430,8 @@ struct push_cas_option {
 		unsigned use_tracking:1;
 		char *refname;
 	} *entry;
-	int nr;
-	int alloc;
+	size_t nr;
+	size_t alloc;
 };
 
 int parseopt_push_cas_option(const struct option *, const char *arg, int unset);

  parent reply	other threads:[~2026-04-28  1:47 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05 22:32 [RFC PATCH 0/2] push: add support for pushing to remote groups Usman Akinyemi
2026-03-05 22:32 ` [RFC PATCH 1/2] remote: move remote group resolution to remote.c Usman Akinyemi
2026-03-06 18:12   ` Junio C Hamano
2026-03-09  0:43     ` Usman Akinyemi
2026-03-05 22:32 ` [RFC PATCH 2/2] push: support pushing to a remote group Usman Akinyemi
2026-03-07  2:12   ` Junio C Hamano
2026-03-09  0:56     ` Usman Akinyemi
2026-03-09 13:38       ` Junio C Hamano
2026-03-18 20:40 ` [RFC PATCH v2 0/2] push: add support for pushing to remote groups Usman Akinyemi
2026-03-18 20:40   ` [RFC PATCH v2 1/2] remote: move remote group resolution to remote.c Usman Akinyemi
2026-03-18 20:40   ` [RFC PATCH v2 2/2] push: support pushing to a remote group Usman Akinyemi
2026-03-18 20:57     ` Junio C Hamano
2026-03-18 21:58     ` Junio C Hamano
2026-03-18 22:25     ` Junio C Hamano
2026-03-19 17:02     ` Junio C Hamano
2026-03-25 18:42       ` Usman Akinyemi
2026-03-18 21:57   ` [RFC PATCH v2 0/2] push: add support for pushing to remote groups Junio C Hamano
2026-03-18 23:13     ` Usman Akinyemi
2026-03-25 19:09   ` [RFC PATCH v3 " Usman Akinyemi
2026-03-25 19:09     ` [RFC PATCH v3 1/2] remote: move remote group resolution to remote.c Usman Akinyemi
2026-03-25 19:09     ` [RFC PATCH v3 2/2] push: support pushing to a remote group Usman Akinyemi
2026-03-25 19:47       ` Junio C Hamano
2026-03-31 22:35         ` Usman Akinyemi
2026-03-31 23:45         ` Usman Akinyemi
2026-04-01 16:56           ` Junio C Hamano
2026-03-27 22:18       ` Junio C Hamano
2026-04-27 14:05     ` [RFC PATCH v3 0/2] push: add support for pushing to remote groups Usman Akinyemi
2026-04-27 14:05       ` [RFC PATCH v4 1/2] remote: move remote group resolution to remote.c Usman Akinyemi
2026-04-27 14:05       ` [RFC PATCH v4 2/2] push: support pushing to a remote group Usman Akinyemi
2026-04-28  1:47       ` Junio C Hamano [this message]
2026-05-03 15:33       ` [RFC PATCH v5 0/3] push: add support for pushing to remote groups Usman Akinyemi
2026-05-03 15:34         ` [RFC PATCH v5 1/3] remote: fix sign-compare warnings in push_cas_option Usman Akinyemi
2026-05-03 15:34         ` [RFC PATCH v5 2/3] remote: move remote group resolution to remote.c Usman Akinyemi
2026-05-03 15:34         ` [RFC PATCH v5 3/3] push: support pushing to a remote group Usman Akinyemi
2026-05-12 15:05           ` Kristoffer Haugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq340f26vx.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=phillip.wood123@gmail.com \
    --cc=ps@pks.im \
    --cc=usmanakinyemi202@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox