Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Usman Akinyemi <usmanakinyemi202@gmail.com>
Cc: christian.couder@gmail.com,  git@vger.kernel.org,
	 me@ttaylorr.com, phillip.wood123@gmail.com,  ps@pks.im
Subject: Re: [RFC PATCH v3 2/2] push: support pushing to a remote group
Date: Wed, 01 Apr 2026 09:56:43 -0700	[thread overview]
Message-ID: <xmqqcy0iwrec.fsf@gitster.g> (raw)
In-Reply-To: <CAPSxiM8Nks16nJCB9N8_bi-ZmQFF71UQEzACrF+pFXKXNuVdKQ@mail.gmail.com> (Usman Akinyemi's message of "Wed, 1 Apr 2026 05:15:12 +0530")

Usman Akinyemi <usmanakinyemi202@gmail.com> writes:

>>
>> I would personally have designed to mimic exactly like "git push r1;
>> git push r2; ..." would do (not concatenated with "&&" but with
>> ";"), which would mean that there is only one single failure mode
>> that would not affect interactions with any other remotes, but I
>> have no strong arguments to choose that design, other than that it
>> would be easy to explain when we later start supporting pushes to
>> multiple remotes in parallel, where a failure to talk to one remote
>> cannot easily affect interaction with other remotes without getting
>> affected by timing issues.
> If we want to have one failure mode i.e continue pushing when there is
> a failure,
> then, we have to use `run_command` to spawn a child process for each
> of the push.

Because you would want to avoid hitting a "die()" while pushing to
the (N-1)th remote, before you push to the Nth remote?

If there is a "now we have attempted to push to all N remotes, and
know the outcome from these N attempts, summarize them and present
the result" phase in the program, then you'd need to spawn sub push
for N times and then the primary process needs to do the summarizing.

If there isn't any such "post push clean-up" phase, we need N-1 sub
pushes and the last one can be done in the primary process.  If that
is possible, that would be ideal, because it makes N==1 case the same
as the traditional "push to a single remote" case.


  reply	other threads:[~2026-04-01 16:56 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05 22:32 [RFC PATCH 0/2] push: add support for pushing to remote groups Usman Akinyemi
2026-03-05 22:32 ` [RFC PATCH 1/2] remote: move remote group resolution to remote.c Usman Akinyemi
2026-03-06 18:12   ` Junio C Hamano
2026-03-09  0:43     ` Usman Akinyemi
2026-03-05 22:32 ` [RFC PATCH 2/2] push: support pushing to a remote group Usman Akinyemi
2026-03-07  2:12   ` Junio C Hamano
2026-03-09  0:56     ` Usman Akinyemi
2026-03-09 13:38       ` Junio C Hamano
2026-03-18 20:40 ` [RFC PATCH v2 0/2] push: add support for pushing to remote groups Usman Akinyemi
2026-03-18 20:40   ` [RFC PATCH v2 1/2] remote: move remote group resolution to remote.c Usman Akinyemi
2026-03-18 20:40   ` [RFC PATCH v2 2/2] push: support pushing to a remote group Usman Akinyemi
2026-03-18 20:57     ` Junio C Hamano
2026-03-18 21:58     ` Junio C Hamano
2026-03-18 22:25     ` Junio C Hamano
2026-03-19 17:02     ` Junio C Hamano
2026-03-25 18:42       ` Usman Akinyemi
2026-03-18 21:57   ` [RFC PATCH v2 0/2] push: add support for pushing to remote groups Junio C Hamano
2026-03-18 23:13     ` Usman Akinyemi
2026-03-25 19:09   ` [RFC PATCH v3 " Usman Akinyemi
2026-03-25 19:09     ` [RFC PATCH v3 1/2] remote: move remote group resolution to remote.c Usman Akinyemi
2026-03-25 19:09     ` [RFC PATCH v3 2/2] push: support pushing to a remote group Usman Akinyemi
2026-03-25 19:47       ` Junio C Hamano
2026-03-31 22:35         ` Usman Akinyemi
2026-03-31 23:45         ` Usman Akinyemi
2026-04-01 16:56           ` Junio C Hamano [this message]
2026-03-27 22:18       ` Junio C Hamano
2026-04-27 14:05     ` [RFC PATCH v3 0/2] push: add support for pushing to remote groups Usman Akinyemi
2026-04-27 14:05       ` [RFC PATCH v4 1/2] remote: move remote group resolution to remote.c Usman Akinyemi
2026-04-27 14:05       ` [RFC PATCH v4 2/2] push: support pushing to a remote group Usman Akinyemi
2026-04-28  1:47       ` [RFC PATCH v3 0/2] push: add support for pushing to remote groups Junio C Hamano
2026-05-03 15:33       ` [RFC PATCH v5 0/3] " Usman Akinyemi
2026-05-03 15:34         ` [RFC PATCH v5 1/3] remote: fix sign-compare warnings in push_cas_option Usman Akinyemi
2026-05-03 15:34         ` [RFC PATCH v5 2/3] remote: move remote group resolution to remote.c Usman Akinyemi
2026-05-03 15:34         ` [RFC PATCH v5 3/3] push: support pushing to a remote group Usman Akinyemi
2026-05-12 15:05           ` Kristoffer Haugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqcy0iwrec.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=phillip.wood123@gmail.com \
    --cc=ps@pks.im \
    --cc=usmanakinyemi202@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox