git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] MaintNotes: use https:// instead of git:// when possible
Date: Tue, 01 Dec 2020 11:07:17 -0800	[thread overview]
Message-ID: <xmqq360pqra2.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <X8Yu5CephK3uvMeV@coredump.intra.peff.net> (Jeff King's message of "Tue, 1 Dec 2020 06:54:12 -0500")

Jeff King <peff@peff.net> writes:

> On Tue, Dec 01, 2020 at 10:58:15AM +0100, Ævar Arnfjörð Bjarmason wrote:
>
>> Change advertised git:// links to https://. These all work as
>> arguments to "git clone", but in addition they also have friendly web
>> interfaces.
>
> This is a good idea, I think. Not only for that reason, but because
> https:// is more secure. You can verify tags from the maintainer's
> signature, of course, but if you are just fetching some refs, you are
> relying on the remote server not to lie to you. With https://, you at
> least have some assurance that it is the remote server you intended to
> talk to, and not a man-in-the-middle over the totally unauthenticated
> git:// protocol.
>
>> This leaves just git://ozlabs.org/~paulus/gitk as the only git://
>> URL. As far as I can tell there's no web interface for it. There is
>> e.g. https://git.ozlabs.org/?p=ppp.git which is a frontend for
>> git://git.ozlabs.org/~paulus/ppp.git, but even though cloning the repo
>> at git://git.ozlabs.org/~paulus/gitk.git works (not the "git" subdomain)
>
> s/not/note/ in this last line?

With or without the tweak, I couldn't figure out what the paragraph
wanted to say.  On the other hand, I didn't quite get why "friendly
web interfaces" matters until trying to read the paragraph again to
realize that it was talking about repository browser like gitweb and
cgit.

I'd probably rephrase the entire proposed commit log message to
something like:

	Most git:// URLs listed for the copies of the Git repository
	have working corresponding https:// URLs that can be given
	to a browser to browse the repository interactively.  List
	https:// URL instead of git:// URL for such repositories.
	The former is also more secure, even though it may be more
	expensive.

without mentioning ozlabs at all.

Thanks.

  reply	other threads:[~2020-12-01 19:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01  5:15 What's cooking in git.git (Nov 2020, #06; Mon, 30) Junio C Hamano
2020-12-01  9:46 ` [PATCH] cook: add github.com/git-vcs/git as a URL Ævar Arnfjörð Bjarmason
2020-12-01  9:58   ` [PATCH] MaintNotes: use https:// instead of git:// when possible Ævar Arnfjörð Bjarmason
2020-12-01 11:54     ` Jeff King
2020-12-01 19:07       ` Junio C Hamano [this message]
2020-12-02  1:43         ` Jeff King
2020-12-01 11:47   ` [PATCH] cook: add github.com/git-vcs/git as a URL Jeff King
2020-12-01 19:10     ` Junio C Hamano
2020-12-02  1:44       ` Jeff King
2020-12-01 18:57   ` Junio C Hamano
2020-12-02  4:33 ` What's cooking in git.git (Nov 2020, #06; Mon, 30) Felipe Contreras
2020-12-02 13:22 ` ds/config-literal-value (was Re: What's cooking in git.git (Nov 2020, #06; Mon, 30)) Derrick Stolee
2020-12-02 22:14   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq360pqra2.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).