From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Aniket Gupta <aniketgupta3001@gmail.com>,
git@vger.kernel.org, christian.couder@gmail.com, cat@malon.dev,
belkid98@gmail.com, phillip.wood123@gmail.com
Subject: Re: [PATCH 0/4] environment: move line ending config variables into repo_config_values
Date: Tue, 03 Nov 2026 09:01:49 -0800 [thread overview]
Message-ID: <xmqq7bitc0hu.fsf@gitster.g> (raw)
In-Reply-To: <aumOHhbTVW0bT3We@pks.im> (Patrick Steinhardt's message of "Tue, 3 Nov 2026 08:32:46 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> On Mon, Oct 26, 2026 at 08:53:57AM -0700, Junio C Hamano wrote:
>> Patrick Steinhardt <ps@pks.im> writes:
>>
>> > While these patches _look_ like they libify Git more, they actually do
>> > the exact opposite right now and tie us more and more to
>> > `the_repository`. So I'm inclined to say that we should hold off merging
>> > these patches until we fix that issue, or otherwise we paint ourselves
>> > into a corner.
>>
>> Could you please volunteer to add a quick patch to add a comment
>> next to the problematic structure to tell people stop moving things
>> there (for now) and point at the message I am responding to?
>
> Sorry, I planned to do that but haven't yet gotten around to it. But I
> see that you've sent it by now via [1]. Thanks!
Ah, I completely forgot about this exchange when I did [1] myself.
Anyway, I'll take it as an Acked-by for it.
Thanks.
>
> Patrick
>
> [1]: <xmqqh5hzjdwr.fsf_-_@gitster.g>
prev parent reply other threads:[~2026-11-03 17:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 22:00 [PATCH 0/4] environment: move line ending config variables into repo_config_values Aniket Gupta
2026-10-24 22:00 ` [PATCH 1/4] convert: pass 'repo' to the working tree conversion functions Aniket Gupta
2026-10-24 22:00 ` [PATCH 2/4] environment: move auto_crlf into repo_config_values Aniket Gupta
2026-10-24 22:00 ` [PATCH 3/4] environment: move core_eol " Aniket Gupta
2026-10-24 22:00 ` [PATCH 4/4] environment: move global_conv_flags_eol " Aniket Gupta
2026-10-26 12:27 ` [PATCH 0/4] environment: move line ending config variables " Patrick Steinhardt
2026-10-26 13:10 ` Aniket Gupta
2026-10-26 13:25 ` Patrick Steinhardt
2026-10-26 15:53 ` Junio C Hamano
2026-11-03 7:32 ` Patrick Steinhardt
2026-11-03 17:01 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7bitc0hu.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=aniketgupta3001@gmail.com \
--cc=belkid98@gmail.com \
--cc=cat@malon.dev \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood123@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox