From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: "Kaartic Sivaraam" <kaartic.sivaraam@gmail.com>,
git@vger.kernel.org, "Jeff King" <peff@peff.net>,
"Todd Zullinger" <tmz@pobox.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH v4 3/8] ci: drop unused "linux-clang" logic
Date: Fri, 16 Oct 2026 08:33:57 -0700 [thread overview]
Message-ID: <xmqq8q3xirru.fsf@gitster.g> (raw)
In-Reply-To: <atCdWdE74-4K5aWc@pks.im> (Patrick Steinhardt's message of "Thu, 15 Oct 2026 11:31:05 +0200")
Patrick Steinhardt <ps@pks.im> writes:
>> On some digging, it seems that 32d5b90590 (Enable Rust by default,
>> 2026-04-09) flipped Rust flags of CI jobs and retained NO_RUST only for this
>> job and the linux-musl-meson jobs. That means, we've been having the NO_RUST
>> flag on a Makefile based job that never existed in the first place which is
>> a bit sad. I wonder if we need to fix the intention at least now and slip
>> the NO_RUST flag into one of the other Makefile based jobs?
>> linux-feature-testbed? Or have a separate job for this?
>>
>> Of course, this is not really a problem with this series per se. So, we can
>> handle it separately if that's preferred.
>
> Yeah, we probably should fix this. But same as with the other things
> that we could do while at it I'd prefer to do those in a subsequent
> patch series.
I would consider resurrecting the no-rust job is in the same spirit
as 8/8 to ensure test coverage for reftable by shuffling jobs
around. I do not mind seeing it done separately, but it is not too
big an effort to throw it into the feature testbed or linux32 job
just to make sure the system builds without rust, and doing so now
would mean we won't forget. And it is only until rust becomes
required anyway.
next prev parent reply other threads:[~2026-10-16 15:33 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 10:01 [PATCH 0/8] ci: some housekeeping and modernizations Patrick Steinhardt
2026-10-08 10:01 ` [PATCH 1/8] t5004: skip SHA-1-only test in SHA-256 repository Patrick Steinhardt
2026-10-08 18:05 ` Junio C Hamano
2026-10-09 5:46 ` Patrick Steinhardt
2026-10-08 10:01 ` [PATCH 2/8] ci: fix "fedora-breaking-changes-meson" job Patrick Steinhardt
2026-10-08 10:01 ` [PATCH 3/8] ci: drop unused "linux-clang" logic Patrick Steinhardt
2026-10-08 10:01 ` [PATCH 4/8] ci: switch away from unsupported i386/ubuntu image Patrick Steinhardt
2026-10-08 15:03 ` Todd Zullinger
2026-10-08 18:12 ` Junio C Hamano
2026-10-09 5:46 ` Patrick Steinhardt
2026-10-08 10:01 ` [PATCH 5/8] ci: rename linux-TEST-vars job Patrick Steinhardt
2026-10-08 10:01 ` [PATCH 6/8] ci: switch away from EOL'd Ubuntu version in linux-exotic Patrick Steinhardt
2026-10-08 10:01 ` [PATCH 7/8] ci: drop now-dead Python 2 coverage Patrick Steinhardt
2026-10-08 10:01 ` [PATCH 8/8] ci: drop redundant linux-reftable job Patrick Steinhardt
2026-10-08 18:18 ` Junio C Hamano
2026-10-09 5:55 ` Patrick Steinhardt
2026-10-09 20:22 ` Junio C Hamano
2026-10-09 11:31 ` [PATCH v2 0/8] ci: some housekeeping and modernizations Patrick Steinhardt
2026-10-09 11:31 ` [PATCH v2 1/8] t5004: skip SHA-1-only test in SHA-256 repository Patrick Steinhardt
2026-10-09 11:31 ` [PATCH v2 2/8] ci: fix "fedora-breaking-changes-meson" job Patrick Steinhardt
2026-10-09 11:32 ` [PATCH v2 3/8] ci: drop unused "linux-clang" logic Patrick Steinhardt
2026-10-09 11:32 ` [PATCH v2 4/8] ci: switch away from unsupported i386/ubuntu image Patrick Steinhardt
2026-10-09 11:32 ` [PATCH v2 5/8] ci: rename linux-TEST-vars job Patrick Steinhardt
2026-10-09 15:31 ` SZEDER Gábor
2026-10-13 7:21 ` Patrick Steinhardt
2026-10-13 14:47 ` Junio C Hamano
2026-10-14 7:03 ` Patrick Steinhardt
2026-10-09 11:32 ` [PATCH v2 6/8] ci: switch away from EOL'd Ubuntu version in linux-exotic Patrick Steinhardt
2026-10-09 11:32 ` [PATCH v2 7/8] ci: drop now-dead Python 2 coverage Patrick Steinhardt
2026-10-09 11:32 ` [PATCH v2 8/8] ci: improve reftable test coverage Patrick Steinhardt
2026-10-14 8:30 ` [PATCH v3 0/8] ci: some housekeeping and modernizations Patrick Steinhardt
2026-10-14 8:30 ` [PATCH v3 1/8] t5004: skip SHA-1-only test in SHA-256 repository Patrick Steinhardt
2026-10-14 9:07 ` Jeff King
2026-10-14 10:34 ` Patrick Steinhardt
2026-10-14 15:04 ` Kaartic Sivaraam
2026-10-15 5:43 ` Patrick Steinhardt
2026-10-14 8:30 ` [PATCH v3 2/8] ci: fix "fedora-breaking-changes-meson" job Patrick Steinhardt
2026-10-14 9:10 ` Jeff King
2026-10-14 10:35 ` Patrick Steinhardt
2026-10-14 11:07 ` Jeff King
2026-10-14 11:18 ` Patrick Steinhardt
2026-10-14 8:30 ` [PATCH v3 3/8] ci: drop unused "linux-clang" logic Patrick Steinhardt
2026-10-14 8:30 ` [PATCH v3 4/8] ci: switch away from unsupported i386/ubuntu image Patrick Steinhardt
2026-10-14 9:17 ` Jeff King
2026-10-14 10:35 ` Patrick Steinhardt
2026-10-14 11:08 ` Jeff King
2026-10-14 8:30 ` [PATCH v3 5/8] ci: rename linux-TEST-vars job Patrick Steinhardt
2026-10-14 9:17 ` Jeff King
2026-10-14 8:30 ` [PATCH v3 6/8] ci: switch away from EOL'd Ubuntu version in linux-feature-testbed Patrick Steinhardt
2026-10-14 9:18 ` Jeff King
2026-10-14 8:30 ` [PATCH v3 7/8] ci: drop now-dead Python 2 coverage Patrick Steinhardt
2026-10-14 8:30 ` [PATCH v3 8/8] ci: improve reftable test coverage Patrick Steinhardt
2026-10-14 9:21 ` Jeff King
2026-10-14 10:35 ` Patrick Steinhardt
2026-10-14 11:13 ` Jeff King
2026-10-14 11:18 ` Patrick Steinhardt
2026-10-14 13:47 ` Jeff King
2026-10-14 9:22 ` [PATCH v3 0/8] ci: some housekeeping and modernizations Jeff King
2026-10-14 14:28 ` Junio C Hamano
2026-10-15 5:43 ` Patrick Steinhardt
2026-10-15 17:12 ` Junio C Hamano
2026-10-15 6:57 ` [PATCH v4 " Patrick Steinhardt
2026-10-15 6:57 ` [PATCH v4 1/8] t5004: fix test creating an archive with large objects under SHA256 Patrick Steinhardt
2026-10-15 6:57 ` [PATCH v4 2/8] ci: fix "fedora-breaking-changes-meson" job Patrick Steinhardt
2026-10-15 6:57 ` [PATCH v4 3/8] ci: drop unused "linux-clang" logic Patrick Steinhardt
2026-10-15 8:36 ` Kaartic Sivaraam
2026-10-15 9:31 ` Patrick Steinhardt
2026-10-16 15:33 ` Junio C Hamano [this message]
2026-10-15 6:57 ` [PATCH v4 4/8] ci: switch away from unsupported i386/ubuntu image Patrick Steinhardt
2026-10-15 6:57 ` [PATCH v4 5/8] ci: rename linux-TEST-vars job Patrick Steinhardt
2026-10-15 6:57 ` [PATCH v4 6/8] ci: switch away from EOL'd Ubuntu version in linux-feature-testbed Patrick Steinhardt
2026-10-15 6:57 ` [PATCH v4 7/8] ci: drop now-dead Python 2 coverage Patrick Steinhardt
2026-10-15 6:57 ` [PATCH v4 8/8] ci: improve reftable test coverage Patrick Steinhardt
2026-10-15 7:06 ` [PATCH v4 0/8] ci: some housekeeping and modernizations Jeff King
2026-10-15 18:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8q3xirru.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kaartic.sivaraam@gmail.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=szeder.dev@gmail.com \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox