From: Junio C Hamano <gitster@pobox.com>
To: "Nikolaus Schuetz via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Phillip Wood <phillip.wood123@gmail.com>,
Nikolaus Schuetz <nikolauspschuetz@gmail.com>
Subject: Re: [PATCH v2] merge-base: add tests for --is-ancestor
Date: Thu, 30 Jul 2026 09:02:50 -0700 [thread overview]
Message-ID: <xmqq8q6slb2t.fsf@gitster.g> (raw)
In-Reply-To: <pull.2186.v2.git.1785392350660.gitgitgadget@gmail.com> (Nikolaus Schuetz via GitGitGadget's message of "Thu, 30 Jul 2026 06:19:09 +0000")
"Nikolaus Schuetz via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Changes since v1, per review:
>
> * Reuse the E---D---C---B---A history and the G/H merges from the "set
> up G and H" test instead of creating a separate repository.
Looks good.
> * Add a test that --is-ancestor requires exactly two commits: too few
> is a usage error (exit 129), while more than two is rejected with
> "--is-ancestor takes exactly two commits" (exit 128).
OK.
Will queue. Thanks.
prev parent reply other threads:[~2026-07-30 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-25 17:00 [PATCH] merge-base: add tests for --is-ancestor Nikolaus Schuetz via GitGitGadget
2026-07-28 22:48 ` Junio C Hamano
2026-07-29 9:39 ` Phillip Wood
2026-07-29 15:31 ` Junio C Hamano
2026-07-30 6:19 ` [PATCH v2] " Nikolaus Schuetz via GitGitGadget
2026-07-30 16:02 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8q6slb2t.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=nikolauspschuetz@gmail.com \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox