Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: "D. Ben Knoble" <ben.knoble+github@gmail.com>,
	 Jeff King <peff@peff.net>,
	 git@vger.kernel.org,
	 "brian m . carlson" <sandals@crustytoothpaste.net>,
	 Ramsay Jones <ramsay@ramsayjones.plus.com>
Subject: Re: [PATCH] meson: wire up USE_NSEC build knob
Date: Sat, 11 Jul 2026 15:46:38 -0700	[thread overview]
Message-ID: <xmqqa4rx9mb5.fsf@gitster.g> (raw)
In-Reply-To: <aktOn-3K41Uhl9cr@pks.im> (Patrick Steinhardt's message of "Mon, 6 Jul 2026 08:43:43 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> I don't think we'd necessarily need a way to detect this. Our current
> build default is to have this disabled, so I'd keep it this way, but
> automatically compile nsec-support into Git if available. And then we
> provide a way for users to opt-in to the new behaviour via the config.
>
> An automated test would of course be nice to have so that we know to
> enable this in cases where we can determine that it works. But with the
> above we'd already make the feature more accessible than it currently
> is, because I'd expect that most distros simply don't enable the build
> toggle at all.

In any case, the discussion tells me that if we were to pursue this
topic further, it would not primarily be about adding the build knob
to meson.build file, but rather a bit more involved to affect the
product for everybody regardless of the build framework used.

So I think it is safe for me discard this topic from my tree for
now, with an invitation to resurrect it as a topic with shifted
focus.

Thanks.

  parent reply	other threads:[~2026-07-11 22:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-20 16:00 [PATCH] meson: wire up USE_NSEC build knob D. Ben Knoble
2026-06-21  1:01 ` Junio C Hamano
2026-06-21 16:41   ` D. Ben Knoble
2026-06-22  8:13   ` Patrick Steinhardt
2026-06-21 17:49 ` Jeff King
2026-06-22  8:13   ` Patrick Steinhardt
2026-06-28  8:18     ` Jeff King
2026-06-28  8:48       ` Jeff King
2026-06-29  0:23         ` brian m. carlson
2026-06-29  6:08       ` Patrick Steinhardt
2026-06-29 21:38         ` Junio C Hamano
2026-06-30  5:43         ` Jeff King
2026-07-03 15:46           ` D. Ben Knoble
2026-07-03 15:46       ` D. Ben Knoble
2026-07-03 15:46     ` D. Ben Knoble
2026-07-06  6:43       ` Patrick Steinhardt
2026-07-07  4:38         ` Jeff King
2026-07-11 22:46         ` Junio C Hamano [this message]
2026-07-13 22:17           ` Ben Knoble

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa4rx9mb5.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ben.knoble+github@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --cc=ramsay@ramsayjones.plus.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox