Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
Cc: git@vger.kernel.org,  christian.couder@gmail.com,
	usmanakinyemi202@gmail.com,  siddharthasthana31@gmail.com,
	kaartic.sivaraam@gmail.com
Subject: Re: [Outreachy PATCH v2] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE
Date: Mon, 26 Oct 2026 11:10:53 -0700	[thread overview]
Message-ID: <xmqqbj8gqqmq.fsf@gitster.g> (raw)
In-Reply-To: <20261014114904.85300-1-okhuomonajayi54@gmail.com> (Okhuomon Ajayi's message of "Wed, 14 Oct 2026 12:49:04 +0100")

Okhuomon Ajayi <okhuomonajayi54@gmail.com> writes:

> Since 84325f0730 (merge,diff: remove the_repository check before
> prefetching blobs, 2026-02-21), diffcore-break.c no longer references
> the_repository, so it does not need USE_THE_REPOSITORY_VARIABLE.
>
> Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
> ---
> Changes since v1:
> - Removed the last paragraph of the commit message, as suggested by
>   Usman. No code was changed.

Thanks for writing and reviewing.  Will queue.

>
>  diffcore-break.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/diffcore-break.c b/diffcore-break.c
> index b5bcc956cc..71d0e48beb 100644
> --- a/diffcore-break.c
> +++ b/diffcore-break.c
> @@ -2,8 +2,6 @@
>   * Copyright (C) 2005 Junio C Hamano
>   */
>  
> -#define USE_THE_REPOSITORY_VARIABLE
> -
>  #include "git-compat-util.h"
>  #include "diffcore.h"
>  #include "hash.h"

      reply	other threads:[~2026-10-26 18:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14  8:12 [Outreachy PATCH] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE Okhuomon Ajayi
2026-10-14 10:24 ` Usman Akinyemi
2026-10-14 10:57   ` Okhuomon Ajayi
2026-10-14 11:10     ` Usman Akinyemi
2026-10-14 11:12       ` Okhuomon Ajayi
2026-10-14 11:49 ` [Outreachy PATCH v2] " Okhuomon Ajayi
2026-10-26 18:10   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbj8gqqmq.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=okhuomonajayi54@gmail.com \
    --cc=siddharthasthana31@gmail.com \
    --cc=usmanakinyemi202@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox