[Outreachy PATCH] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE

[Outreachy PATCH] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE

[Okhuomon Ajayi]

Since 84325f0730 (merge,diff: remove the_repository check before
prefetching blobs, 2026-02-21), diffcore-break.c no longer references
the_repository, so it does not need USE_THE_REPOSITORY_VARIABLE.

Without this, new use of the_repository in this file would fail to
compile.

Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
---
 diffcore-break.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/diffcore-break.c b/diffcore-break.c
index b5bcc956cc..71d0e48beb 100644
--- a/diffcore-break.c
+++ b/diffcore-break.c
@@ -2,8 +2,6 @@
  * Copyright (C) 2005 Junio C Hamano
  */
 
-#define USE_THE_REPOSITORY_VARIABLE
-
 #include "git-compat-util.h"
 #include "diffcore.h"
 #include "hash.h"
-- 
2.54.0

Re: [Outreachy PATCH] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE

[Usman Akinyemi]

>
> Since 84325f0730 (merge,diff: remove the_repository check before
> prefetching blobs, 2026-02-21), diffcore-break.c no longer references
> the_repository, so it does not need USE_THE_REPOSITORY_VARIABLE.
Good finding.
>
> Without this, new use of the_repository in this file would fail to
> compile.
I do not understand this statement.
>
> Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
> ---
>  diffcore-break.c | 2 --
>  1 file changed, 2 deletions(-)

Re: [Outreachy PATCH] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE

[Okhuomon Ajayi]

On Wed, Oct 14, 2026 at 11:25 AM Usman Akinyemi
<usmanakinyemi202@gmail.com> wrote:

> > Without this, new use of the_repository in this file would fail to
> > compile.
> I do not understand this statement.


Thanks for the review.
I meant that since the USE_THE_REPOSITORY_VARIABLE has been removed, any
future use of  the_repository without adding the
USE_THE_REPOSITORY_VARIABLE macro would fail to compile.
I see that my statement above is not clear, I would modify the
wordings and send in a v2.

Re: [Outreachy PATCH] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE

[Usman Akinyemi]

>
> Thanks for the review.
> I meant that since the USE_THE_REPOSITORY_VARIABLE has been removed, any
> future use of  the_repository without adding the
> USE_THE_REPOSITORY_VARIABLE macro would fail to compile.
> I see that my statement above is not clear, I would modify the
> wordings and send in a v2.
You do not need to add that. That is literally like explaining if and
else statements
in the commit message. It is not needed.

Thanks.

Re: [Outreachy PATCH] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE

[Okhuomon Ajayi]

On Wed, Oct 14, 2026 at 12:11 PM Usman Akinyemi
<usmanakinyemi202@gmail.com> wrote:
> > Thanks for the review.
> > I meant that since the USE_THE_REPOSITORY_VARIABLE has been removed, any
> > future use of  the_repository without adding the
> > USE_THE_REPOSITORY_VARIABLE macro would fail to compile.
> > I see that my statement above is not clear, I would modify the
> > wordings and send in a v2.
> You do not need to add that. That is literally like explaining if and
> else statements
> in the commit message. It is not needed.
>
> Thanks.

Yeah, i would take it out of the commit message in my v2
Thanks

[Outreachy PATCH v2] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE

[Okhuomon Ajayi]

Since 84325f0730 (merge,diff: remove the_repository check before
prefetching blobs, 2026-02-21), diffcore-break.c no longer references
the_repository, so it does not need USE_THE_REPOSITORY_VARIABLE.

Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
---
Changes since v1:
- Removed the last paragraph of the commit message, as suggested by
  Usman. No code was changed.

 diffcore-break.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/diffcore-break.c b/diffcore-break.c
index b5bcc956cc..71d0e48beb 100644
--- a/diffcore-break.c
+++ b/diffcore-break.c
@@ -2,8 +2,6 @@
  * Copyright (C) 2005 Junio C Hamano
  */
 
-#define USE_THE_REPOSITORY_VARIABLE
-
 #include "git-compat-util.h"
 #include "diffcore.h"
 #include "hash.h"
-- 
2.54.0

Re: [Outreachy PATCH v2] diffcore-break: remove USE_THE_REPOSITORY_VARIABLE

[Junio C Hamano]

Okhuomon Ajayi <okhuomonajayi54@gmail.com> writes:

> Since 84325f0730 (merge,diff: remove the_repository check before
> prefetching blobs, 2026-02-21), diffcore-break.c no longer references
> the_repository, so it does not need USE_THE_REPOSITORY_VARIABLE.
>
> Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
> ---
> Changes since v1:
> - Removed the last paragraph of the commit message, as suggested by
>   Usman. No code was changed.

Thanks for writing and reviewing.  Will queue.

>
>  diffcore-break.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/diffcore-break.c b/diffcore-break.c
> index b5bcc956cc..71d0e48beb 100644
> --- a/diffcore-break.c
> +++ b/diffcore-break.c
> @@ -2,8 +2,6 @@
>   * Copyright (C) 2005 Junio C Hamano
>   */
>  
> -#define USE_THE_REPOSITORY_VARIABLE
> -
>  #include "git-compat-util.h"
>  #include "diffcore.h"
>  #include "hash.h"