From: Junio C Hamano <gitster@pobox.com>
To: "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH v2] diff: avoid misleading statement about -l option
Date: Fri, 14 Aug 2026 07:26:41 -0700 [thread overview]
Message-ID: <xmqqbjb4rd5q.fsf@gitster.g> (raw)
In-Reply-To: <pull.2035.v2.git.1786673186855.gitgitgadget@gmail.com> (Elijah Newren via GitGitGadget's message of "Fri, 14 Aug 2026 02:06:26 +0000")
"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
> diff --git a/diff.c b/diff.c
> index 589c1969e4..c593066592 100644
> --- a/diff.c
> +++ b/diff.c
> @@ -6186,7 +6186,7 @@ struct option *add_diff_options(const struct option *opts,
> N_("continue listing the history of a file beyond renames"),
> PARSE_OPT_NOARG, diff_opt_follow),
> OPT_INTEGER('l', NULL, &options->rename_limit,
> - N_("prevent rename/copy detection if the number of rename/copy targets exceeds given limit")),
> + N_("limit to cheap rename/copy detection if the number of rename/copy targets exceeds this value")),
That is still a mouthful and it does not help that rename/copy
appears twice, but that trait is shared with the original, so let's
leave it outside the topic to improve it. If somebody is inclined
to, he or she can do so later.
Will mark it for 'next'. Thanks.
>
> OPT_GROUP(N_("Diff algorithm options")),
> OPT_CALLBACK_F(0, "minimal", options, NULL,
>
> base-commit: 2c78326f810173a4f3aefd8021f1e07575412481
prev parent reply other threads:[~2026-08-14 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 6:42 [PATCH] diff: avoid misleading statement about -l option Elijah Newren via GitGitGadget
2026-08-12 14:22 ` Junio C Hamano
2026-08-12 15:42 ` Elijah Newren
2026-08-14 2:06 ` [PATCH v2] " Elijah Newren via GitGitGadget
2026-08-14 14:26 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbjb4rd5q.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox