From: Junio C Hamano <gitster@pobox.com>
To: lilinchao@oschina.cn
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] transport.c: modify comment in transport_get().
Date: Wed, 24 Mar 2021 13:23:10 -0700 [thread overview]
Message-ID: <xmqqblb8xpw1.fsf@gitster.g> (raw)
In-Reply-To: <f64df5f88c6211eb9c9a0024e87935e7@oschina.cn> (lilinchao@oschina.cn's message of "Wed, 24 Mar 2021 13:36:47 +0800")
lilinchao@oschina.cn writes:
> From: lilinchao <lilinchao@oschina.cn>
>
> Signed-off-by: lilinchao <lilinchao@oschina.cn>
> ---
> transport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/transport.c b/transport.c
> index 1c4ab676d1..71b3d44cf3 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -1078,7 +1078,7 @@ struct transport *transport_get(struct remote *remote, const char *url)
> data->conn = NULL;
> data->got_remote_heads = 0;
> } else {
> - /* Unknown protocol in URL. Pass to external handler. */
> + /* Http/https and other unknown protocol in URL. Pass to external handler. */
The previous block says
/*
* These are builtin smart transports; "allowed" transports
* will be checked individually in git_connect.
*/
where it lists file:// git:// and ssh:// URLs. And contrasting with
that, it should be clear "unknown" refers to "not a builtin that is
known to the C code linked to the same binary" and includes http://
and https://.
IOW, I am not sure adding "http/https and other" to make it an
overlong line is worth doing.
Thanks.
next prev parent reply other threads:[~2021-03-24 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 5:36 [PATCH 1/2] transport.c: modify comment in transport_get() lilinchao
2021-03-24 20:23 ` Junio C Hamano [this message]
[not found] ` <c6ee6c9e8cde11eba7e5a4badb2c2b1175929@pobox.com>
2021-03-25 3:39 ` lilinchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqblb8xpw1.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=lilinchao@oschina.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).