Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Hussain Sitamouwala <husainsitamuwala21@gmail.com>
Cc: git@vger.kernel.org,  christian.couder@gmail.com
Subject: Re: [PATCH v2] doc: describe promisor remote fetch order
Date: Mon, 09 Nov 2026 07:45:01 -0800	[thread overview]
Message-ID: <xmqqcxse101u.fsf@gitster.g> (raw)
In-Reply-To: <20261108192232.681-1-husainsitamuwala21@gmail.com> (Hussain Sitamouwala's message of "Sun, 8 Nov 2026 19:22:32 +0000")

Hussain Sitamouwala <husainsitamuwala21@gmail.com> writes:

> Hi Junio,
>
> Thanks for the review.
>
>> I think the entire sentence after "If a fetch from a remote fails"
>> should be removed.
>
> You are right. The fallback is already implied by "tried one after
> the other", so the sentence adds nothing. I will remove it from the
> documentation and also drop the matching clause from the commit
> message.

Was that extra "not wrong per-se but totally unnecessary without
adding any new information" sentence added by LLM by any chance?
Just being curious.

Thanks.

  reply	other threads:[~2026-11-09 15:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08  7:19 [PATCH v2] doc: describe promisor remote fetch order Hussain Sitamouwala
2026-11-08 18:45 ` Junio C Hamano
2026-11-08 19:07   ` Hussain Sitamouwala
2026-11-08 19:03 ` Junio C Hamano
2026-11-08 19:12   ` Hussain Sitamouwala
2026-11-08 19:16   ` Junio C Hamano
2026-11-08 19:22     ` Hussain Sitamouwala
2026-11-09 15:45       ` Junio C Hamano [this message]
2026-11-10 12:58         ` Hussain Sitamouwala
2026-11-08 21:38     ` [PATCH] environment: move assume_unchanged into repo_config_values Hussain Sitamouwala
2026-11-08 19:55 ` [PATCH v3] doc: describe promisor remote fetch order Hussain Sitamouwala
2026-11-09  5:09   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqcxse101u.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=husainsitamuwala21@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox