From: Junio C Hamano <gitster@pobox.com>
To: Hussain Sitamouwala <husainsitamuwala21@gmail.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com
Subject: Re: [PATCH v2] doc: describe promisor remote fetch order
Date: Sun, 08 Nov 2026 11:16:30 -0800 [thread overview]
Message-ID: <xmqqo6bz2kxd.fsf@gitster.g> (raw)
In-Reply-To: <xmqqse1b2ljp.fsf@gitster.g> (Junio C. Hamano's message of "Sun, 08 Nov 2026 11:03:06 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Hussain Sitamouwala <husainsitamuwala21@gmail.com> writes:
>
>> Explain that promisor remotes accepted from a server are tried
>> before other promisor remotes, and that the remaining objects are
>> requested from the next remote when a fetch fails. The ordering
>
> Well written. "next" sounded a bit strange thing to say in the
> context, but it was understandable.
>
> Assuming that I understood what the author wanted to say correctly,
> that is ;-), so let's double-check. Would it mean the same thing if
> we replace "next remote" with "other promisor remotes"?
After thinking about this a bit more, I know why I thought this was
strange.
>> When fetching objects, promisor remotes are tried one after the other
>> +client accepted from a server's advertisement are tried before the
>> +other promisor remotes. If a fetch from a remote fails, the objects
>> +that are still missing are requested from the next remote.
I think the entire sentence after "If a fetch from a remote fails"
should be removed. You already established that while fetching,
remotes are tried one after the other. What does it mean? We try
promisor A, and if the fetch from it fails to obtain certain
objects, we try promisor B, and then C, and so on. We already said
that and you clarified in which order these promisors A and B and C
are consulted.
So, there is absolutely nothing left to be said. The last sentence,
while it may not say anything wrong, is simply redundant without
adding any new information.
next prev parent reply other threads:[~2026-11-08 19:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 7:19 [PATCH v2] doc: describe promisor remote fetch order Hussain Sitamouwala
2026-11-08 18:45 ` Junio C Hamano
2026-11-08 19:07 ` Hussain Sitamouwala
2026-11-08 19:03 ` Junio C Hamano
2026-11-08 19:12 ` Hussain Sitamouwala
2026-11-08 19:16 ` Junio C Hamano [this message]
2026-11-08 19:22 ` Hussain Sitamouwala
2026-11-09 15:45 ` Junio C Hamano
2026-11-10 12:58 ` Hussain Sitamouwala
2026-11-08 21:38 ` [PATCH] environment: move assume_unchanged into repo_config_values Hussain Sitamouwala
2026-11-08 19:55 ` [PATCH v3] doc: describe promisor remote fetch order Hussain Sitamouwala
2026-11-09 5:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo6bz2kxd.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=husainsitamuwala21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox