Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Cc: Usman Akinyemi <usmanakinyemi202@gmail.com>,
	 Shashank S via GitGitGadget <gitgitgadget@gmail.com>,
	 git@vger.kernel.org,
	 Christian Couder <christian.couder@gmail.com>,
	 Siddharth Asthana <siddharthasthana31@gmail.com>,
	 Shashank S <shashu8660@gmail.com>
Subject: Re: [PATCH] t0081: modernize the code testing whether a file exists
Date: Thu, 05 Nov 2026 13:28:00 -0800	[thread overview]
Message-ID: <xmqqecczrmsf.fsf@gitster.g> (raw)
In-Reply-To: <2a050885-a1c2-48d6-b561-3c2ea0a05dbf@gmail.com> (Kaartic Sivaraam's message of "Fri, 23 Oct 2026 12:26:51 +0530")

Kaartic Sivaraam <kaartic.sivaraam@gmail.com> writes:

> Got it. Does the following change read better?
>
> diff --git a/links/mentoring/soc/SoC-2026-Microprojects.md 
> b/links/mentoring/soc/SoC-2026-Microprojects.md
> index 41354b50..17519e2d 100644
> --- a/links/mentoring/soc/SoC-2026-Microprojects.md
> +++ b/links/mentoring/soc/SoC-2026-Microprojects.md
> @@ -49,8 +49,9 @@ with Git's dedicated test helpers like 
> `test_path_is_file`.
>   - Start small: Pick a test file with just a few instances to convert
>   - Run the test suite after your changes to ensure nothing breaks
>   - Follow Git's commit message style
> -- You _do not need to_ include the command you used to find the instances
> -  in your commit message
> +- You can include the command you used to find the instances in your
> +  cover letter or between the three-dash line and the diffstat, whichever
> +  is appropriate. Do not mention it in your commit message

Yes, this reads much better.  It clearly guides contributors to put
the command below the three-dash line or in the cover letter without
cluttering the commit message.

  reply	other threads:[~2026-11-05 21:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14  7:26 [PATCH] t0081: modernize the code testing whether a file exists Shashank S via GitGitGadget
2026-10-14  9:49 ` Usman Akinyemi
2026-10-14 21:47   ` Junio C Hamano
2026-10-15  7:02     ` Shashank S
2026-10-15 11:43     ` Kaartic Sivaraam
2026-10-15 17:10       ` Junio C Hamano
2026-10-23  6:56         ` Kaartic Sivaraam
2026-11-05 21:28           ` Junio C Hamano [this message]
2026-11-06  7:36             ` Kaartic Sivaraam
2026-10-15  6:51   ` Shashank S
2026-10-15 10:47 ` [PATCH v2] [Outreachy] " Shashank S via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqecczrmsf.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=shashu8660@gmail.com \
    --cc=siddharthasthana31@gmail.com \
    --cc=usmanakinyemi202@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox