Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Tian Yuchen <cat@malon.dev>,
	 git@vger.kernel.org,  ps@pks.im, phillip.wood123@gmail.com,
	 stolee@gmail.com
Subject: Re: [PATCH v3 0/2] environment: move ignore_case into repo_config_values
Date: Fri, 10 Jul 2026 08:01:30 -0700	[thread overview]
Message-ID: <xmqqechaga7p.fsf@gitster.g> (raw)
In-Reply-To: <9ade3ca2-fdd9-c5da-3d87-a754a0643d6f@gmx.de> (Johannes Schindelin's message of "Fri, 10 Jul 2026 12:29:47 +0200 (CEST)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Hi Yuchen,
>
> On Fri, 10 Jul 2026, Tian Yuchen wrote:
>
>> compat/win32/path-utils.c --- Is it appropriate to include the
>> repository.h header file?
>
> Since path-utils.c implements logic that is repository-dependent (as your
> patch points out), including that header is appropriate.

Thanks, both.  Let's merge the topic down to 'next' then.

      reply	other threads:[~2026-07-10 15:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-17 15:49 [PATCH 0/2] environment: move ignore_case into repo_config_values Tian Yuchen
2026-06-17 15:49 ` [PATCH 1/2] " Tian Yuchen
2026-06-17 17:16   ` Junio C Hamano
2026-06-18 10:56     ` Tian Yuchen
2026-06-17 15:49 ` [PATCH 2/2] config: use repo_get_ignore_case() to access core.ignorecase Tian Yuchen
2026-06-18 11:42 ` [PATCH v2 0/2] environment: move ignore_case into repo_config_values Tian Yuchen
2026-06-18 11:42   ` [PATCH v2 1/2] " Tian Yuchen
2026-06-18 11:42   ` [PATCH v2 2/2] config: use repo_ignore_case() to access core.ignorecase Tian Yuchen
2026-06-18 13:14   ` [PATCH v2 0/2] environment: move ignore_case into repo_config_values Junio C Hamano
2026-06-19 16:01     ` Tian Yuchen
2026-06-19 15:51   ` [PATCH v3 " Tian Yuchen
2026-06-19 15:51     ` [PATCH v3 1/2] " Tian Yuchen
2026-06-19 15:51     ` [PATCH v3 2/2] config: use repo_ignore_case() to access core.ignorecase Tian Yuchen
2026-06-21 20:16     ` [PATCH v3 0/2] environment: move ignore_case into repo_config_values Junio C Hamano
2026-06-22 16:45       ` Tian Yuchen
2026-06-22 18:01         ` Junio C Hamano
2026-07-10 10:29     ` Johannes Schindelin
2026-07-10 15:01       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqechaga7p.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=cat@malon.dev \
    --cc=git@vger.kernel.org \
    --cc=phillip.wood123@gmail.com \
    --cc=ps@pks.im \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox