Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH] completion: remove 'git column' from porcelain commands
Date: Fri, 11 Dec 2015 10:16:17 -0800	[thread overview]
Message-ID: <xmqqegesg8b2.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1449835500-24844-1-git-send-email-szeder@ira.uka.de> ("SZEDER Gábor"'s message of "Fri, 11 Dec 2015 13:05:00 +0100")

SZEDER Gábor <szeder@ira.uka.de> writes:

> 'git column' is an internal helper, so it should not be offered on
> 'git <TAB>' along with porcelain commands.
>
> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
> ---

I think this makes sense.
Objections?

>  contrib/completion/git-completion.bash | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 111b05302b..5dec8778f7 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -664,6 +664,7 @@ __git_list_porcelain_commands ()
>  		check-mailmap)    : plumbing;;
>  		check-ref-format) : plumbing;;
>  		checkout-index)   : plumbing;;
> +		column)           : internal helper;;
>  		commit-tree)      : plumbing;;
>  		count-objects)    : infrequent;;
>  		credential)       : credentials;;

  reply	other threads:[~2015-12-11 18:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11 12:05 [PATCH] completion: remove 'git column' from porcelain commands SZEDER Gábor
2015-12-11 18:16 ` Junio C Hamano [this message]
2015-12-11 18:21   ` Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqegesg8b2.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    --cc=szeder@ira.uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox