* [PATCH] completion: remove 'git column' from porcelain commands
@ 2015-12-11 12:05 SZEDER Gábor
2015-12-11 18:16 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: SZEDER Gábor @ 2015-12-11 12:05 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, SZEDER Gábor
'git column' is an internal helper, so it should not be offered on
'git <TAB>' along with porcelain commands.
Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
---
contrib/completion/git-completion.bash | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 111b05302b..5dec8778f7 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -664,6 +664,7 @@ __git_list_porcelain_commands ()
check-mailmap) : plumbing;;
check-ref-format) : plumbing;;
checkout-index) : plumbing;;
+ column) : internal helper;;
commit-tree) : plumbing;;
count-objects) : infrequent;;
credential) : credentials;;
--
2.6.3.420.g7bbb372
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] completion: remove 'git column' from porcelain commands
2015-12-11 12:05 [PATCH] completion: remove 'git column' from porcelain commands SZEDER Gábor
@ 2015-12-11 18:16 ` Junio C Hamano
2015-12-11 18:21 ` Duy Nguyen
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2015-12-11 18:16 UTC (permalink / raw)
To: Nguyễn Thái Ngọc Duy; +Cc: git, SZEDER Gábor
SZEDER Gábor <szeder@ira.uka.de> writes:
> 'git column' is an internal helper, so it should not be offered on
> 'git <TAB>' along with porcelain commands.
>
> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
> ---
I think this makes sense.
Objections?
> contrib/completion/git-completion.bash | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 111b05302b..5dec8778f7 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -664,6 +664,7 @@ __git_list_porcelain_commands ()
> check-mailmap) : plumbing;;
> check-ref-format) : plumbing;;
> checkout-index) : plumbing;;
> + column) : internal helper;;
> commit-tree) : plumbing;;
> count-objects) : infrequent;;
> credential) : credentials;;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] completion: remove 'git column' from porcelain commands
2015-12-11 18:16 ` Junio C Hamano
@ 2015-12-11 18:21 ` Duy Nguyen
0 siblings, 0 replies; 3+ messages in thread
From: Duy Nguyen @ 2015-12-11 18:21 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Git Mailing List, SZEDER Gábor
On Fri, Dec 11, 2015 at 7:16 PM, Junio C Hamano <gitster@pobox.com> wrote:
> SZEDER Gábor <szeder@ira.uka.de> writes:
>
>> 'git column' is an internal helper, so it should not be offered on
>> 'git <TAB>' along with porcelain commands.
>>
>> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
>> ---
>
> I think this makes sense.
> Objections?
Not from me.
--
Duy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-11 18:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-11 12:05 [PATCH] completion: remove 'git column' from porcelain commands SZEDER Gábor
2015-12-11 18:16 ` Junio C Hamano
2015-12-11 18:21 ` Duy Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox