From: Junio C Hamano <gitster@pobox.com>
To: parovozik <kaliugov@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] doc: remove unnecessary commas in git-add and git-rm documentation
Date: Thu, 24 Sep 2026 09:20:58 -0700 [thread overview]
Message-ID: <xmqqh5je4o45.fsf@gitster.g> (raw)
In-Reply-To: <20260924074041.1428-1-kaliugov@gmail.com> (parovozik's message of "Thu, 24 Sep 2026 11:40:41 +0400")
parovozik <kaliugov@gmail.com> writes:
Here at the top of the message before your sign-off can be left
blank for a trivial change like this patch whose motivation is so
obviously good and whose correctness is so clear.
> Signed-off-by: parovozik <kaliugov@gmail.com>
Documentation/SubmittingPatches::[[real-name]]; we prefer to see a
name that is not a "handle".
> ---
For a single-patch topic, here under the three-dash line is where
you describe what improvements were made relative to previous
iteration(s) of your work.
> Documentation/git-add.adoc | 2 +-
> Documentation/git-rm.adoc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc
> index 16b06e38e1..3fc2513a2d 100644
> --- a/Documentation/git-add.adoc
> +++ b/Documentation/git-add.adoc
> @@ -223,7 +223,7 @@ for `git add --no-all <pathspec>...`, i.e. ignored removed files.
>
> `--`::
> This option can be used to separate command-line options from
> - the list of files, (useful when filenames might be mistaken
> + the list of files (useful when filenames might be mistaken
> for command-line options).
>
>
> diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc
> index b5ead86796..67061e961f 100644
> --- a/Documentation/git-rm.adoc
> +++ b/Documentation/git-rm.adoc
> @@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].
>
> `--`::
> This option can be used to separate command-line options from
> - the list of files, (useful when filenames might be mistaken
> + the list of files (useful when filenames might be mistaken
> for command-line options).
>
> `--cached`::
next prev parent reply other threads:[~2026-09-24 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 21:31 [PATCH] doc: remove unnecessary comma in git-rm documentation parovozik
2026-09-23 22:00 ` Junio C Hamano
2026-09-24 7:40 ` [PATCH v2] doc: remove unnecessary commas in git-add and " parovozik
2026-09-24 16:20 ` Junio C Hamano [this message]
2026-09-29 21:02 ` [PATCH v3] " Khan Zimov
2026-09-29 21:05 ` [PATCH v4] " Khan Zimov
2026-10-01 15:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh5je4o45.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kaliugov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox