* [PATCH] doc: remove unnecessary comma in git-rm documentation
@ 2026-09-23 21:31 parovozik
2026-09-23 22:00 ` Junio C Hamano
0 siblings, 1 reply; 7+ messages in thread
From: parovozik @ 2026-09-23 21:31 UTC (permalink / raw)
To: git; +Cc: parovozik
Signed-off-by: parovozik <kaliugov@gmail.com>
---
Documentation/git-rm.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc
index b5ead86796..67061e961f 100644
--- a/Documentation/git-rm.adoc
+++ b/Documentation/git-rm.adoc
@@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].
`--`::
This option can be used to separate command-line options from
- the list of files, (useful when filenames might be mistaken
+ the list of files (useful when filenames might be mistaken
for command-line options).
`--cached`::
--
2.52.0.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] doc: remove unnecessary comma in git-rm documentation
2026-09-23 21:31 [PATCH] doc: remove unnecessary comma in git-rm documentation parovozik
@ 2026-09-23 22:00 ` Junio C Hamano
2026-09-24 7:40 ` [PATCH v2] doc: remove unnecessary commas in git-add and " parovozik
0 siblings, 1 reply; 7+ messages in thread
From: Junio C Hamano @ 2026-09-23 22:00 UTC (permalink / raw)
To: parovozik; +Cc: git
parovozik <kaliugov@gmail.com> writes:
> Signed-off-by: parovozik <kaliugov@gmail.com>
Documentation/SubmittingPatches::[[real-name]]
> ---
> Documentation/git-rm.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
$ git grep -C1 'separate command-line' Documentation/
shows that ...
> diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc
> index b5ead86796..67061e961f 100644
> --- a/Documentation/git-rm.adoc
> +++ b/Documentation/git-rm.adoc
> @@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].
>
> `--`::
> This option can be used to separate command-line options from
> - the list of files, (useful when filenames might be mistaken
> + the list of files (useful when filenames might be mistaken
> for command-line options).
... an identical text appears once more elsewhere. It would be a
good idea to keep them in sync.
>
> `--cached`::
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] doc: remove unnecessary commas in git-add and git-rm documentation
2026-09-23 22:00 ` Junio C Hamano
@ 2026-09-24 7:40 ` parovozik
2026-09-24 16:20 ` Junio C Hamano
0 siblings, 1 reply; 7+ messages in thread
From: parovozik @ 2026-09-24 7:40 UTC (permalink / raw)
To: git; +Cc: gitster, parovozik
Signed-off-by: parovozik <kaliugov@gmail.com>
---
Documentation/git-add.adoc | 2 +-
Documentation/git-rm.adoc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc
index 16b06e38e1..3fc2513a2d 100644
--- a/Documentation/git-add.adoc
+++ b/Documentation/git-add.adoc
@@ -223,7 +223,7 @@ for `git add --no-all <pathspec>...`, i.e. ignored removed files.
`--`::
This option can be used to separate command-line options from
- the list of files, (useful when filenames might be mistaken
+ the list of files (useful when filenames might be mistaken
for command-line options).
diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc
index b5ead86796..67061e961f 100644
--- a/Documentation/git-rm.adoc
+++ b/Documentation/git-rm.adoc
@@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].
`--`::
This option can be used to separate command-line options from
- the list of files, (useful when filenames might be mistaken
+ the list of files (useful when filenames might be mistaken
for command-line options).
`--cached`::
--
2.52.0.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] doc: remove unnecessary commas in git-add and git-rm documentation
2026-09-24 7:40 ` [PATCH v2] doc: remove unnecessary commas in git-add and " parovozik
@ 2026-09-24 16:20 ` Junio C Hamano
2026-09-29 21:02 ` [PATCH v3] " Khan Zimov
2026-09-29 21:05 ` [PATCH v4] " Khan Zimov
0 siblings, 2 replies; 7+ messages in thread
From: Junio C Hamano @ 2026-09-24 16:20 UTC (permalink / raw)
To: parovozik; +Cc: git
parovozik <kaliugov@gmail.com> writes:
Here at the top of the message before your sign-off can be left
blank for a trivial change like this patch whose motivation is so
obviously good and whose correctness is so clear.
> Signed-off-by: parovozik <kaliugov@gmail.com>
Documentation/SubmittingPatches::[[real-name]]; we prefer to see a
name that is not a "handle".
> ---
For a single-patch topic, here under the three-dash line is where
you describe what improvements were made relative to previous
iteration(s) of your work.
> Documentation/git-add.adoc | 2 +-
> Documentation/git-rm.adoc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc
> index 16b06e38e1..3fc2513a2d 100644
> --- a/Documentation/git-add.adoc
> +++ b/Documentation/git-add.adoc
> @@ -223,7 +223,7 @@ for `git add --no-all <pathspec>...`, i.e. ignored removed files.
>
> `--`::
> This option can be used to separate command-line options from
> - the list of files, (useful when filenames might be mistaken
> + the list of files (useful when filenames might be mistaken
> for command-line options).
>
>
> diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc
> index b5ead86796..67061e961f 100644
> --- a/Documentation/git-rm.adoc
> +++ b/Documentation/git-rm.adoc
> @@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].
>
> `--`::
> This option can be used to separate command-line options from
> - the list of files, (useful when filenames might be mistaken
> + the list of files (useful when filenames might be mistaken
> for command-line options).
>
> `--cached`::
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] doc: remove unnecessary commas in git-add and git-rm documentation
2026-09-24 16:20 ` Junio C Hamano
@ 2026-09-29 21:02 ` Khan Zimov
2026-09-29 21:05 ` [PATCH v4] " Khan Zimov
1 sibling, 0 replies; 7+ messages in thread
From: Khan Zimov @ 2026-09-29 21:02 UTC (permalink / raw)
To: gitster; +Cc: git
Signed-off-by: Khan Zimov <kaliugov@gmail.com>
---
Documentation/git-add.adoc | 2 +-
Documentation/git-rm.adoc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc
index 16b06e38e1..3fc2513a2d 100644
--- a/Documentation/git-add.adoc
+++ b/Documentation/git-add.adoc
@@ -223,7 +223,7 @@ for `git add --no-all <pathspec>...`, i.e. ignored removed files.
`--`::
This option can be used to separate command-line options from
- the list of files, (useful when filenames might be mistaken
+ the list of files (useful when filenames might be mistaken
for command-line options).
diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc
index b5ead86796..67061e961f 100644
--- a/Documentation/git-rm.adoc
+++ b/Documentation/git-rm.adoc
@@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].
`--`::
This option can be used to separate command-line options from
- the list of files, (useful when filenames might be mistaken
+ the list of files (useful when filenames might be mistaken
for command-line options).
`--cached`::
--
2.52.0.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v4] doc: remove unnecessary commas in git-add and git-rm documentation
2026-09-24 16:20 ` Junio C Hamano
2026-09-29 21:02 ` [PATCH v3] " Khan Zimov
@ 2026-09-29 21:05 ` Khan Zimov
2026-10-01 15:31 ` Junio C Hamano
1 sibling, 1 reply; 7+ messages in thread
From: Khan Zimov @ 2026-09-29 21:05 UTC (permalink / raw)
To: gitster; +Cc: git
Signed-off-by: Khan Zimov <kaliugov@gmail.com>
---
Changes since v3:
- Add changes description.
Changes since v2:
- Use real name in Signed-off-by (sorry, handle before).
Changes since v1:
- Also fix the same text in git-add.adoc, so that both files
stay in sync.
Documentation/git-add.adoc | 2 +-
Documentation/git-rm.adoc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc
index 16b06e38e1..3fc2513a2d 100644
--- a/Documentation/git-add.adoc
+++ b/Documentation/git-add.adoc
@@ -223,7 +223,7 @@ for `git add --no-all <pathspec>...`, i.e. ignored removed files.
`--`::
This option can be used to separate command-line options from
- the list of files, (useful when filenames might be mistaken
+ the list of files (useful when filenames might be mistaken
for command-line options).
diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc
index b5ead86796..67061e961f 100644
--- a/Documentation/git-rm.adoc
+++ b/Documentation/git-rm.adoc
@@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].
`--`::
This option can be used to separate command-line options from
- the list of files, (useful when filenames might be mistaken
+ the list of files (useful when filenames might be mistaken
for command-line options).
`--cached`::
--
2.52.0.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v4] doc: remove unnecessary commas in git-add and git-rm documentation
2026-09-29 21:05 ` [PATCH v4] " Khan Zimov
@ 2026-10-01 15:31 ` Junio C Hamano
0 siblings, 0 replies; 7+ messages in thread
From: Junio C Hamano @ 2026-10-01 15:31 UTC (permalink / raw)
To: Khan Zimov; +Cc: git
Khan Zimov <kaliugov@gmail.com> writes:
> Signed-off-by: Khan Zimov <kaliugov@gmail.com>
> ---
Thanks. Both changes look good. Let me mark the topic for 'next'.
> diff --git a/Documentation/git-add.adoc b/Documentation/git-add.adoc
> index 16b06e38e1..3fc2513a2d 100644
> --- a/Documentation/git-add.adoc
> +++ b/Documentation/git-add.adoc
> @@ -223,7 +223,7 @@ for `git add --no-all <pathspec>...`, i.e. ignored removed files.
>
> `--`::
> This option can be used to separate command-line options from
> - the list of files, (useful when filenames might be mistaken
> + the list of files (useful when filenames might be mistaken
> for command-line options).
>
>
> diff --git a/Documentation/git-rm.adoc b/Documentation/git-rm.adoc
> index b5ead86796..67061e961f 100644
> --- a/Documentation/git-rm.adoc
> +++ b/Documentation/git-rm.adoc
> @@ -61,7 +61,7 @@ For more details, see the _<pathspec>_ entry in linkgit:gitglossary[7].
>
> `--`::
> This option can be used to separate command-line options from
> - the list of files, (useful when filenames might be mistaken
> + the list of files (useful when filenames might be mistaken
> for command-line options).
>
> `--cached`::
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-10-01 15:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-23 21:31 [PATCH] doc: remove unnecessary comma in git-rm documentation parovozik
2026-09-23 22:00 ` Junio C Hamano
2026-09-24 7:40 ` [PATCH v2] doc: remove unnecessary commas in git-add and " parovozik
2026-09-24 16:20 ` Junio C Hamano
2026-09-29 21:02 ` [PATCH v3] " Khan Zimov
2026-09-29 21:05 ` [PATCH v4] " Khan Zimov
2026-10-01 15:31 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox