Fixing translation errors in gits error messages

Fixing translation errors in gits error messages

[Alangi Derick]

Hello,
     I am embarking on the project of fixing all the translation
errors in the entire git source codes while maintaining the strings in
error(_( function the same. I will be sending a series of patches
which will include the fixes for all translation errors for files
containing them until i finish all this errors.

I ran the command:
 git grep --cached -F -e 'error("' > fix_translation.txt
so that i can track all the files with the errors and fix them file
after file manually.

Regards
Alangi Derick Ndimnain

Re: Fixing translation errors in gits error messages

[Junio C Hamano]

Alangi Derick <alangiderick@gmail.com> writes:

> I ran the command:
>  git grep --cached -F -e 'error("' > fix_translation.txt
> so that i can track all the files with the errors and fix them file
> after file manually.

That is a good first step to find candidates, but you have to be
careful to sift that output into ones that needs marking and others.
Some strings are for plumbing output that must never be translated.

Re: Fixing translation errors in gits error messages

[Alangi Derick]

Just for further clarifications, just tell me if i am correct. This is
and example of that i am fixing right?
void NORETURN die_resolve_conflict(const char *me)

 {
  error_resolve_conflict(me);
- die("Exiting because of an unresolved conflict.");
+ die(_("Exiting because of an unresolved conflict."));
 }

Just tell me if i am on the right track.

Regards
Alangi Derick Ndimnain