Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Harald Nordgren <haraldnordgren@gmail.com>
Cc: git@vger.kernel.org,
	 Harald Nordgren via GitGitGadget <gitgitgadget@gmail.com>,
	 "D. Ben Knoble" <ben.knoble@gmail.com>
Subject: Re: [PATCH v3] object-name: explain why <rev>~N fails in a shallow clone
Date: Thu, 05 Nov 2026 13:22:29 -0800	[thread overview]
Message-ID: <xmqqik2brn1m.fsf@gitster.g> (raw)
In-Reply-To: <xmqqy0bbhyit.fsf@gitster.g> (Junio C. Hamano's message of "Mon, 02 Nov 2026 10:35:38 -0800")

Junio C Hamano <gitster@pobox.com> writes:

> Harald Nordgren <haraldnordgren@gmail.com> writes:
>
>>> We unfortunately haven't seen many folks interested in this change.
>>> Is anybody interested in reviewing the patch to give it a push?
>>>
>>> Unless we see some volunteers to give it a review in a few weeks, I
>>> will discard the topic out of my tree, as 'seen' has been crowded
>>> with topics that have been collecting dust without getting many
>>> reviews.
>>
>> Is it possible that maybe the review process needs to change if too
>> many things are getting stuck? Rather than discarding acceptable work.
>
> If it were acceptable, it would have long been in 'next' and
> 'master', though.  One of the important criteria for being
> acceptable is whether others find it a reasonable change to make to
> the system, and I do not know of a way to show that other than by
> positive reviews.
>
> And that is why I pinged the thread again.

And after a few days, nobody in this thread is supportive of this
topic.  It is very unfortunate that the discussion thread that
starts at https://lore.kernel.org/git/xmqqtslzlhbm.fsf@gitster.g/,
which was meant to invite people who are supportive of this change
to talk about its merits, has been cluttered with messages that are
only about the review process, which I was hoping would happen
elsewhere [*].


[Reference]

 * https://lore.kernel.org/git/xmqq1p93ofjx.fsf@gitster.g/

      reply	other threads:[~2026-11-05 21:22 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-20  9:53 [PATCH] object-name: explain why <ref>~N fails in a shallow clone Harald Nordgren via GitGitGadget
2026-09-20 21:59 ` D. Ben Knoble
2026-09-21 16:50 ` Junio C Hamano
2026-09-21 22:17   ` Harald Nordgren
2026-09-21 23:00     ` Junio C Hamano
2026-09-22 13:38 ` [PATCH v2] shallow: advise when a walk stops at a shallow boundary Harald Nordgren via GitGitGadget
2026-09-22 21:20   ` Junio C Hamano
2026-09-23 18:55 ` [PATCH v3] object-name: explain why <rev>~N fails in a shallow clone Harald Nordgren via GitGitGadget
2026-11-02  9:21   ` Junio C Hamano
2026-11-02 10:06     ` Harald Nordgren
2026-11-02 11:01       ` Kristoffer Haugsbakk
2026-11-02 11:07         ` Harald Nordgren
2026-11-02 12:24           ` Patrick Steinhardt
2026-11-02 12:44             ` Kristoffer Haugsbakk
2026-11-02 14:07             ` Harald Nordgren
2026-11-02 14:31               ` Patrick Steinhardt
2026-11-02 14:48                 ` Harald Nordgren
2026-11-02 14:36             ` Phillip Wood
2026-11-02 14:52               ` Harald Nordgren
2026-11-02 18:55               ` Junio C Hamano
2026-11-02 18:40             ` Junio C Hamano
2026-11-02 12:34           ` Kristoffer Haugsbakk
2026-11-02 14:10             ` Harald Nordgren
2026-11-02 14:33               ` Patrick Steinhardt
2026-11-02 18:35       ` Junio C Hamano
2026-11-05 21:22         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqik2brn1m.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=haraldnordgren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox