Re: [Microproject v2] describe: do not translate --debug output

[Junio C Hamano <gitster@pobox.com>]

Antoni Borowski <antekborowski11@gmail.com> writes:

> @@ -477,14 +477,14 @@ static void describe_commit(struct commit *cmit, struct strbuf *dst)
>  		}
>  		for (cur_match = 0; cur_match < match_cnt; cur_match++) {
>  			struct possible_tag *t = &all_matches[cur_match];
> -			fprintf(stderr, " %-*s %8d %s\n",
> +			fprintf(stderr, "Debug:  %-*s %8d %s\n",
>  				label_width, _(prio_names[t->name->prio]),
>  				t->depth, t->name->path);
>  		}

This one has _(translation) still lurking here.  prio_names[] should
not be translated.

prio_names[] is defined as file-scope static.

    static const char *prio_names[] = {
            N_("head"), N_("lightweight"), N_("annotated"),
    };

In describe_commit(), the length of _(prio_names[]) is measured only
for debugging purposes (which is outside the pre-context of the
above hunk), and they are shown with the fprintf() we see above.

The values in prio_names[] should lose N_() around them, and all _()
around prio_names[] should bbe removed to make this conversion
complete.  Perhaps prio_names[] should be moved to that if (debug)
block, which is the only user of that array.  It may even make sense
to rename prio_names[] to make it clear that it is only used for
debugging output and nothing else.

So, earlier I said this looks ready for 'next', but no, it still
needs a bit more work.