Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Grayson Gordon <graysongordon1@gmail.com>
Cc: git@vger.kernel.org,  peff@peff.net,  avarab@gmail.com,  ps@pks.im
Subject: Re: [PATCH v6] http: add http.sslVerifyStatus to check stapled OCSP responses
Date: Fri, 28 Aug 2026 10:20:31 -0700	[thread overview]
Message-ID: <xmqqld9q40ww.fsf@gitster.g> (raw)
In-Reply-To: <CALgUfNjd_y-e-zTKJ31o8_bQuRw8wFWe=sdsf2KJ7LOmmO21aQ@mail.gmail.com> (Grayson Gordon's message of "Fri, 28 Aug 2026 09:51:45 -0400")

Grayson Gordon <graysongordon1@gmail.com> writes:

> Junio,
>
> Yes, I was hoping for clarity on how thorough we wanted the testing to
> be. Patrick added a lot of great stuff that I’m happy to use if that’s
> your preference, but we also talked about wanting to keep the tests
> succinct. Please let me know what you feel is most appropriate.

If you can keep them succinct but still test the essential bits,
that would be great, but I am not sure if that is a great question
to ask me ;-)  Patrick?  You said "not 100% sure given the complexity",
but which parts make you feel iffy?  They do look involved but seem
to cover the situations we do care about, except we seem not to test
when the server does not explicitly say "this is still good", or am
I not reading the tests correctly?

Thanks.

      reply	other threads:[~2026-08-28 17:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 17:02 [PATCH] http: add http.sslVerifyStatus to check stapled OCSP responses graysongordon-gl
2026-08-11 19:28 ` Junio C Hamano
2026-08-11 20:44 ` [PATCH v2] " graysongordon-gl
2026-08-12  6:25   ` Patrick Steinhardt
2026-08-12 15:53     ` Grayson Gordon
2026-08-12 14:17   ` Junio C Hamano
2026-08-12 18:25     ` [PATCH v3] " graysongordon-gl
2026-08-12 21:34       ` Junio C Hamano
2026-08-13 16:06         ` Junio C Hamano
2026-08-17 18:52           ` [PATCH v4] " graysongordon-gl
2026-08-17 19:19             ` Junio C Hamano
2026-08-18  7:50             ` Patrick Steinhardt
2026-08-18 14:51               ` Grayson Gordon
2026-08-19  8:14                 ` Patrick Steinhardt
2026-08-18 16:40               ` Junio C Hamano
2026-08-18 19:37           ` [PATCH v5] " graysongordon-gl
2026-08-18 20:12             ` Junio C Hamano
2026-08-18 21:22               ` Grayson Gordon
2026-08-18 21:48           ` [PATCH v6] " graysongordon-gl
2026-08-26 22:01             ` Junio C Hamano
2026-08-28 13:51               ` Grayson Gordon
2026-08-28 17:20                 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqld9q40ww.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=graysongordon1@gmail.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox