From: Junio C Hamano <gitster@pobox.com>
To: "Daniel Martí via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "M Hickford" <mirth.hickford@gmail.com>,
"Mantas Mikulėnas" <grawity@gmail.com>,
"Patrick Steinhardt" <ps@pks.im>, "Daniel Martí" <mvdan@mvdan.cc>
Subject: Re: [PATCH v2] credential/libsecret: load secrets explicitly
Date: Mon, 02 Nov 2026 01:31:14 -0800 [thread overview]
Message-ID: <xmqqpkwnlgv1.fsf@gitster.g> (raw)
In-Reply-To: <pull.2372.v2.git.git.1790549181518.gitgitgadget@gmail.com> ("Daniel Martí via GitGitGadget"'s message of "Sun, 27 Sep 2026 22:46:21 +0000")
"Daniel Martí via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
>
> keyring_get() searches with SECRET_SEARCH_LOAD_SECRETS, then passes
> secret_item_get_secret() of the first match unchecked to
> ...
> An inaccessible item now produces a useful error message instead of
> the assertion failures, and git still falls back to prompting. The
> race needs a concurrent process or a locked keyring to trigger, so
> there is no test.
>
> Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
> ---
It seems that unfortunately we saw interest or reviews from nobody
since this v2 was sent. Anybody interested enough to review it now
to resurrect?
Unless we see some volunteers to give it a review in a few weeks, I
will discard the topic out of my tree, as 'seen' has been crowded
with topics that have been collecting dust without getting many
reviews.
next prev parent reply other threads:[~2026-11-02 9:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 22:40 [PATCH] credential/libsecret: load secrets explicitly Daniel Martí via GitGitGadget
2026-08-20 15:00 ` Daniel Martí
2026-08-20 19:05 ` Junio C Hamano
2026-08-22 20:47 ` Daniel Martí
2026-09-21 21:54 ` Daniel Martí
2026-09-21 22:52 ` Junio C Hamano
2026-09-24 7:00 ` M Hickford
2026-09-27 22:45 ` Daniel Martí
2026-09-27 22:46 ` [PATCH v2] " Daniel Martí via GitGitGadget
2026-09-28 7:37 ` Daniel Martí
2026-11-02 9:31 ` Junio C Hamano [this message]
2026-11-05 14:37 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpkwnlgv1.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=grawity@gmail.com \
--cc=mirth.hickford@gmail.com \
--cc=mvdan@mvdan.cc \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox