Re: [PATCH RFC 1/3] cat-file: extract the transport ownership from get_remote_info()

[Junio C Hamano <gitster@pobox.com>]

Pablo Sabater <pabloosabaterr@gmail.com> writes:

> get_remote_info() receives the name of the remote and from there it
> builds the transport and at the end closes it.
>
> To be able to reuse the connection for multiple batches in a subsequent
> commit, it is needed to extract that responsibility from
> get_remote_info() and instead have it in its caller,
> parse_cmd_remote_object_info(), which will handle the batches.

Makes sense.

> While at it, rename the transport variable 'gtransport' to 'transport',
> as it looks like a global when it's not.

Good move.  We started (not particularly this program but the
transport layer in general) with a global instance of transport
object called gtransport, but the ones that we create on demand and
release after we are done are of course local and it is misleading
to use such a prefix.

> +	if (!transport->smart_options)
> +		die(_("smart options required"));

Is this an end-user facing error message?  I am not sure a user who
saw this message can figure out what went wrong or how to correct
it.