Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <ttaylorr@openai.com>
Cc: git@vger.kernel.org,  Jeff King <peff@peff.net>,
	 Ted Nyman <tnyman@openai.com>,
	 Elijah Newren <newren@github.com>
Subject: Re: [PATCH v2 0/8] repack: various corner cases for cruft-less MIDXs
Date: Wed, 04 Nov 2026 14:48:18 -0800	[thread overview]
Message-ID: <xmqqqzh0z00d.fsf@gitster.g> (raw)
In-Reply-To: <xmqqse1o4g8t.fsf@gitster.g> (Junio C. Hamano's message of "Thu, 29 Oct 2026 09:35:14 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Taylor Blau <ttaylorr@openai.com> writes:
>
>> On Tue, Oct 27, 2026 at 05:27:02PM -0700, Junio C Hamano wrote:
>>> Taylor Blau <ttaylorr@openai.com> writes:
>>>
>>> > This is a reroll of [1]. Thanks to Stolee, Junio, and Peff for
>>> > reviewing.
>>> > ...
>>> > Thanks in advance for your review!
>>>
>>> I am trying to eject stale topics out of my tree, and the discussion
>>> on this topic is about to pass the 1-month mark.  It seems that
>>> comments on half of them are "looks good" and the rest are "just as
>>> confusing as the original without improvement".  How viable is this
>>> topic?  Are we still improving on it, or has it long passed the
>>> point of diminishing returns that nobody is interested in polishing
>>> it any longer?
>>
>> This one should be ready to go as-is!
>>
>> Thanks,
>> Taylor
>
> Hmph, the question was not meant to be answered by the author,
> though ;-)

OK, so I bit the bullet and read the patches and their existing
review discussions again myself.  I too were confused by pretty much
the same things Peff commented on being confusing X-<, but I do not
have concrete improvement ideas to offer right now.

      reply	other threads:[~2026-11-04 22:48 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30  1:28 [PATCH 0/4] repack: various corner cases for cruft-less MIDXs Taylor Blau
2026-09-30  1:28 ` [PATCH 1/4] pack-objects: introduce `stdin_packs_context` struct Taylor Blau
2026-09-30 17:42   ` Junio C Hamano
2026-10-01  3:13     ` Taylor Blau
2026-09-30  1:28 ` [PATCH 2/4] pack-objects: ensure tree/tag closure with '--stdin-packs=follow' Taylor Blau
2026-09-30 17:51   ` Junio C Hamano
2026-09-30 18:16   ` Derrick Stolee
2026-10-01  3:14     ` Taylor Blau
2026-10-01 23:22     ` Elijah Newren
2026-10-02  0:51       ` Taylor Blau
2026-10-02 23:02         ` Jeff King
2026-09-30 20:31   ` Jeff King
2026-10-01  3:18     ` Taylor Blau
2026-09-30  1:28 ` [PATCH 3/4] repack: retain cruft packs in MIDXs after incremental repacks Taylor Blau
2026-09-30 20:45   ` Jeff King
2026-10-01  3:21     ` Taylor Blau
2026-09-30  1:28 ` [PATCH 4/4] repack: retain cruft packs in MIDXs containing kept packs Taylor Blau
2026-09-30 20:53   ` Jeff King
2026-10-01  3:35     ` Taylor Blau
2026-09-30 20:55 ` [PATCH 0/4] repack: various corner cases for cruft-less MIDXs Jeff King
2026-10-01  3:37   ` Taylor Blau
2026-10-01  4:11 ` [PATCH v2 0/8] " Taylor Blau
2026-10-01  4:11   ` [PATCH v2 1/8] pack-objects: introduce `stdin_packs_context` struct Taylor Blau
2026-10-01  4:11   ` [PATCH v2 2/8] pack-objects: ensure tree/tag closure with '--stdin-packs=follow' Taylor Blau
2026-10-02 23:13     ` Jeff King
2026-10-03  0:55       ` Taylor Blau
2026-10-03  1:06         ` Jeff King
2026-10-01  4:11   ` [PATCH v2 3/8] repack: retain cruft packs in MIDXs after incremental repacks Taylor Blau
2026-10-01  4:11   ` [PATCH v2 4/8] repack: use a sorted list for explicitly kept packs Taylor Blau
2026-10-02 23:16     ` Jeff King
2026-10-01  4:11   ` [PATCH v2 5/8] repack: follow kept packs when omitting cruft from the MIDX Taylor Blau
2026-10-02 23:25     ` Jeff King
2026-10-03  0:50       ` Taylor Blau
2026-10-01  4:11   ` [PATCH v2 6/8] repack: track the preferred pack explicitly in MIDX write steps Taylor Blau
2026-10-02 23:28     ` Jeff King
2026-10-03  1:00       ` Taylor Blau
2026-10-03  1:07         ` Jeff King
2026-10-01  4:12   ` [PATCH v2 7/8] repack: defer allocating the append plan's write step Taylor Blau
2026-10-01  4:12   ` [PATCH v2 8/8] repack: include required packs in incremental MIDX writes Taylor Blau
2026-10-02 23:41     ` Jeff King
2026-10-03  1:01       ` Taylor Blau
2026-10-28  0:27   ` [PATCH v2 0/8] repack: various corner cases for cruft-less MIDXs Junio C Hamano
2026-10-28  0:37     ` Taylor Blau
2026-10-29 16:35       ` Junio C Hamano
2026-11-04 22:48         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqqzh0z00d.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=newren@github.com \
    --cc=peff@peff.net \
    --cc=tnyman@openai.com \
    --cc=ttaylorr@openai.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox