From: Junio C Hamano <gitster@pobox.com>
To: "Jayesh Daga via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Justin Tobler <jltobler@gmail.com>,
Ayush Chandekar <ayu.chandekar@gmail.com>,
Siddharth Asthana <siddharthasthana31@gmail.com>,
Jayesh Daga <jayeshdaga99@gmail.com>
Subject: Re: [PATCH v2 0/2] unpack-trees: use explicit repository in trace2 calls
Date: Tue, 09 Jun 2026 14:41:04 -0700 [thread overview]
Message-ID: <xmqqqzmfz91r.fsf@gitster.g> (raw)
In-Reply-To: <xmqqldf7y95a.fsf@gitster.g> (Junio C. Hamano's message of "Tue, 31 Mar 2026 14:35:45 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> "Jayesh Daga via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> Jayesh Daga (2):
>> unpack-trees: use repository from index instead of global
>> unpack-trees: use repository from index instead of global
>
> That is unusual to have two commits with identical title and
> identical proposed log messages yet with different patch text.
>
> Do you perhaps want to squash them into a single commit?
After not hearing anything for full two months, I just decided to
squash these two patches into one, as the second one looked clearly
like "ooops, I screwed up and left one pice behind, so here is an
incremental update". I'll mark the result for 'next'.
prev parent reply other threads:[~2026-06-09 21:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 20:13 [PATCH] unpack-trees: use explicit repository in trace2 calls Jayesh Daga via GitGitGadget
2026-03-31 5:31 ` Patrick Steinhardt
2026-03-31 15:32 ` Junio C Hamano
2026-03-31 20:27 ` Junio C Hamano
2026-03-31 15:34 ` [PATCH v2 0/2] " Jayesh Daga via GitGitGadget
2026-03-31 15:34 ` [PATCH v2 1/2] unpack-trees: use repository from index instead of global Jayesh Daga via GitGitGadget
2026-03-31 15:34 ` [PATCH v2 2/2] " Jayesh Daga via GitGitGadget
2026-03-31 21:35 ` [PATCH v2 0/2] unpack-trees: use explicit repository in trace2 calls Junio C Hamano
2026-06-09 21:41 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqqzmfz91r.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ayu.chandekar@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jayeshdaga99@gmail.com \
--cc=jltobler@gmail.com \
--cc=siddharthasthana31@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox